Battleship using pnpm #9
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfarah-if
force-pushed
the
feat/battleships-kata
branch
4 times, most recently
from
f315b77 to
929383c
Compare
Refactor to add switch Refactor to add types as concept easier to understand and read Add a board Extend to adding a print Made sure concept worked but too many in one commit
Names and types extracted from the code Reduced duplication Reduced big functions
Create failing test for the edge cases when invalid coordinates are provided
Create failing tests for the game service Resolve the issues with the game service edge cases Outer tests passing
Fix bug introduced previously with oversimplifying ships Refactor names Implement the game state for players Simplify mocks and tests
vfarah-if
force-pushed
the
feat/battleships-kata
branch
from
929383c to
8ebc7dd
Compare
Refactored a ShotResult for an error message Refactored big start method Extract more guards
vfarah-if
force-pushed
the
feat/battleships-kata
branch
from
bfa3243 to
bfc20cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.