fix: resolve button transparency in dark mode for scrollToBottom #311
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jamdaniels is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
@jamdaniels can you generate a patch changeset file pnpm changeset? Then I can merge. Great work 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the
scrollToBottombutton was transparent in dark mode, making it difficult to see against the background.I have added
dark:bg-backgroundanddark:hover:bg-mutedto ensure the button remains visible and consistent with the shadcn/ui aesthetic in dark themes.Note: This addresses the transparency issue specifically for the outline variant. Other variants may still exhibit transparency behaviors inherited from the base button primitives, but as this is an edge case, I think a targeted fix for this component is the most practical approach.
Related Issues
none
Changes
Screenshots
Testing
pnpm test(Playwright tests passed).