Use Regexp.exec instead of replace for side-effects
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
steven-tey
reviewed
Aug 1, 2022
Contributor
steven-tey
left a comment
steven-tey
left a comment
There was a problem hiding this comment.
Left a couple of comments!
| // actually matched, so that we can extract the appropriate keyword. | ||
| combineText(post).replace(termsRegex, (_, ...terms: string[]) => { | ||
| let match; | ||
| while ((match = termsRegex.exec(combined))) { |
Contributor
There was a problem hiding this comment.
is this an equals sign = or an equality == comparison?
Contributor
Author
There was a problem hiding this comment.
Equals. In this situation, the extra parens are meant to indicate that this is an intentional assignment. See https://eslint.org/docs/latest/rules/no-cond-assign
|
|
||
| text.replace(scanner, (_, ...terms) => { | ||
| let match; | ||
| while ((match = scanner.exec(text))) { |
Contributor
There was a problem hiding this comment.
Should this be an equality == comparison?
There was a problem hiding this comment.
No, scanner.exec(text) checks null. So == is not needed.
Contributor
|
Could we add a description so it's clear what this PR solves? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
String.p.replaceuses that are only used for side-effects with a fasterRegExp.p.execloop. This avoids the string allocation of the output string, and makes it a little more clear the loop is used for side-effects.