-
Notifications
You must be signed in to change notification settings - Fork 0
Test mcp #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Test mcp #163
Conversation
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
…Quarto version Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
…protocol-servers' into test-mcp
|
@copilot fix the pkgdown website; make sure it renders properly |
|
@d-morrison I've opened a new pull request, #164, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive development environment configuration and documentation to enhance the contributor experience through MCP (Model Context Protocol) integration, dev containers, and VS Code optimizations. It also includes a new "Getting Started" vignette demonstrating the main package workflow.
- Adds MCP server configuration for AI-enhanced development with filesystem, GitHub, Git, and web search capabilities
- Provides complete dev container setup for instant, consistent development environments
- Includes VS Code configuration with R-optimized settings, recommended extensions, and quick tasks
- Creates detailed DEVELOPMENT.md guide covering setup, workflows, and best practices
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vignettes/articles/getting-started.qmd | New comprehensive tutorial covering data loading, simulation, MCMC modeling, and visualization |
| pkgdown/_pkgdown.yml | Reorganizes documentation with "Get started" and "Developer Notes" sections |
| NEWS.md | Documents pkgdown reorganization and new Getting Started guide |
| DEVELOPMENT.md | Complete development guide with setup instructions, MCP details, and workflows |
| DESCRIPTION | Version bump and adds sessioninfo dependency |
| .vscode/tasks.json | Defines quick tasks for common R package operations |
| .vscode/settings.json | R-specific editor configuration with Copilot integration |
| .vscode/extensions.json | Recommended VS Code extensions for R development |
| .gitignore | Excludes Quarto notebook files |
| .github/mcp/verify-mcp.sh | Verification script for MCP configuration |
| .github/mcp/mcp-config.json | MCP server definitions for development tools |
| .github/mcp/SUMMARY.md | Overview of MCP and development environment additions |
| .github/mcp/STRUCTURE.md | Visual documentation of development environment structure |
| .github/mcp/README.md | MCP setup and usage guide |
| .github/copilot-instructions.md | Enhanced with development environment and MCP sections |
| .devcontainer/setup.sh | Automated environment setup script |
| .devcontainer/devcontainer.json | Container specification with features and extensions |
| .devcontainer/README.md | Dev container usage documentation |
| .Rbuildignore | Excludes new development configuration from package builds |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@copilot fix pkgdown workflow |
|
@d-morrison I've opened a new pull request, #165, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
…verage, add to pkgdown Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
…redundant postprocess_jags_output call Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
[WIP] Fix pkgdown website rendering issues
Fix pkgdown workflow: correct file paths and update deprecated actions
|
📖 https://ucd-serg.github.io/serodynamics/preview/pr163 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
.github/workflows/pkgdown.yaml
Outdated
| repos = "https://cloud.r-project.org", | ||
| type = "source", | ||
| verbose = TRUE) | ||
| withr::local_options(warn = 2) |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation on line 92 is incorrect. It should align with the install.packages call above (3 spaces indentation from the start), not have extra leading whitespace. This will cause the R code to fail with a syntax error.
.github/mcp/mcp-config.json
Outdated
| "command": "npx", | ||
| "args": [ | ||
| "-y", | ||
| "@modelcontextprotocol/server-brave-search" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this server archived?
| "@modelcontextprotocol/server-filesystem", | ||
| "/home/runner/work/serodynamics/serodynamics" | ||
| ], | ||
| "description": "Provides file system access to the serodynamics repository for reading and writing files, searching code, and managing the project structure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot does this server enable copilot to alter the main branch?
|
@d-morrison I've opened a new pull request, #168, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.
.github/workflows/pkgdown.yaml
Outdated
| withr::local_options(warn = 2) | ||
| library(rjags) | ||
| library(runjags) | ||
| runjags::findJAGS() | ||
| runjags::testjags() |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is incorrect. Lines 93-96 should be aligned with the other R commands (lines 88-91). Currently, they have extra leading spaces that make them inconsistent with the surrounding code.
| withr::local_options(warn = 2) | |
| library(rjags) | |
| library(runjags) | |
| runjags::findJAGS() | |
| runjags::testjags() | |
| withr::local_options(warn = 2) | |
| library(rjags) | |
| library(runjags) | |
| runjags::findJAGS() | |
| runjags::testjags() |
.vscode/settings.json
Outdated
| "r.rterm.windows": "C:\\Program Files\\R\\R-4.1.0\\bin\\R.exe", | ||
| "r.rpath.linux": "/usr/bin/R", | ||
| "r.rpath.mac": "/usr/local/bin/R", | ||
| "r.rpath.windows": "C:\\Program Files\\R\\R-4.1.0\\bin\\R.exe", |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded R version "R-4.1.0" in the Windows path is outdated and too specific. This will break for users who have R 4.2.0 or later installed. Consider using a more flexible path or documenting that users should update this to match their installed R version. A common practice is to use "R\R-4.1.0" as a placeholder with a comment instructing users to update the version number.
| "r.rterm.windows": "C:\\Program Files\\R\\R-4.1.0\\bin\\R.exe", | |
| "r.rpath.linux": "/usr/bin/R", | |
| "r.rpath.mac": "/usr/local/bin/R", | |
| "r.rpath.windows": "C:\\Program Files\\R\\R-4.1.0\\bin\\R.exe", | |
| // Update this path to match your installed R version on Windows, e.g. R-4.4.0 | |
| "r.rterm.windows": "C:\\Program Files\\R\\R-x.y.z\\bin\\R.exe", | |
| "r.rpath.linux": "/usr/bin/R", | |
| "r.rpath.mac": "/usr/local/bin/R", | |
| // Update this path to match your installed R version on Windows, e.g. R-4.4.0 | |
| "r.rpath.windows": "C:\\Program Files\\R\\R-x.y.z\\bin\\R.exe", |
| "/home/runner/work/serodynamics/serodynamics" | ||
| ], | ||
| "description": "Provides file system access to the serodynamics repository for reading and writing files, searching code, and managing the project structure" | ||
| }, | ||
| "github": { | ||
| "command": "npx", | ||
| "args": [ | ||
| "-y", | ||
| "@modelcontextprotocol/server-github" | ||
| ], | ||
| "env": { | ||
| "GITHUB_PERSONAL_ACCESS_TOKEN": "${GITHUB_TOKEN}" | ||
| }, | ||
| "description": "Integrates with GitHub for repository operations, issue tracking, pull requests, and workflow management" | ||
| }, | ||
| "git": { | ||
| "command": "npx", | ||
| "args": [ | ||
| "-y", | ||
| "@modelcontextprotocol/server-git", | ||
| "--repository", | ||
| "/home/runner/work/serodynamics/serodynamics" |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded repository path "/home/runner/work/serodynamics/serodynamics" is specific to GitHub Actions runner environments and won't work for local development or other CI systems. This path should either be configurable or documented that users need to update it to match their local repository location. Consider using a placeholder like "/path/to/serodynamics" with documentation instructing users to update it, or use environment variable substitution if supported by the MCP implementation.
.devcontainer/setup.sh
Outdated
|
|
||
| # Install package dependencies | ||
| echo "Installing package dependencies..." | ||
| Rscript -e "if (!requireNamespace('pak', quietly = TRUE)) install.packages('pak', repos = 'https://cloud.r-project.org'); pak::local_install_dev_deps(dependencies = TRUE)" |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pak package is installed twice: first in line 38 as part of the development packages array, and then checked again in line 46 with a conditional install. This is redundant. Since pak is already installed in line 38, the conditional check in line 46 is unnecessary and can be simplified to just "pak::local_install_dev_deps(dependencies = TRUE)".
| Rscript -e "if (!requireNamespace('pak', quietly = TRUE)) install.packages('pak', repos = 'https://cloud.r-project.org'); pak::local_install_dev_deps(dependencies = TRUE)" | |
| Rscript -e "pak::local_install_dev_deps(dependencies = TRUE)" |
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@d-morrison I've opened a new pull request, #169, to work on those changes. Once the pull request is ready, I'll request review from you. |
…al Brave Search server Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Address PR review feedback: fix indentation, update configuration paths, replace archived server
No description provided.