Skip to content

Conversation

@d-morrison
Copy link
Collaborator

No description provided.

Copilot AI and others added 7 commits January 6, 2026 04:36
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
…Quarto version

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 7, 2026 07:21
@d-morrison
Copy link
Collaborator Author

@copilot fix the pkgdown website; make sure it renders properly

Copy link
Contributor

Copilot AI commented Jan 7, 2026

@d-morrison I've opened a new pull request, #164, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive development environment configuration and documentation to enhance the contributor experience through MCP (Model Context Protocol) integration, dev containers, and VS Code optimizations. It also includes a new "Getting Started" vignette demonstrating the main package workflow.

  • Adds MCP server configuration for AI-enhanced development with filesystem, GitHub, Git, and web search capabilities
  • Provides complete dev container setup for instant, consistent development environments
  • Includes VS Code configuration with R-optimized settings, recommended extensions, and quick tasks
  • Creates detailed DEVELOPMENT.md guide covering setup, workflows, and best practices

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vignettes/articles/getting-started.qmd New comprehensive tutorial covering data loading, simulation, MCMC modeling, and visualization
pkgdown/_pkgdown.yml Reorganizes documentation with "Get started" and "Developer Notes" sections
NEWS.md Documents pkgdown reorganization and new Getting Started guide
DEVELOPMENT.md Complete development guide with setup instructions, MCP details, and workflows
DESCRIPTION Version bump and adds sessioninfo dependency
.vscode/tasks.json Defines quick tasks for common R package operations
.vscode/settings.json R-specific editor configuration with Copilot integration
.vscode/extensions.json Recommended VS Code extensions for R development
.gitignore Excludes Quarto notebook files
.github/mcp/verify-mcp.sh Verification script for MCP configuration
.github/mcp/mcp-config.json MCP server definitions for development tools
.github/mcp/SUMMARY.md Overview of MCP and development environment additions
.github/mcp/STRUCTURE.md Visual documentation of development environment structure
.github/mcp/README.md MCP setup and usage guide
.github/copilot-instructions.md Enhanced with development environment and MCP sections
.devcontainer/setup.sh Automated environment setup script
.devcontainer/devcontainer.json Container specification with features and extensions
.devcontainer/README.md Dev container usage documentation
.Rbuildignore Excludes new development configuration from package builds

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@d-morrison
Copy link
Collaborator Author

@copilot fix pkgdown workflow

Copy link
Contributor

Copilot AI commented Jan 7, 2026

@d-morrison I've opened a new pull request, #165, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 9 commits January 7, 2026 08:14
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
…verage, add to pkgdown

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
…redundant postprocess_jags_output call

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
[WIP] Fix pkgdown website rendering issues
Copilot AI review requested due to automatic review settings January 8, 2026 03:04
Fix pkgdown workflow: correct file paths and update deprecated actions
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

📖 https://ucd-serg.github.io/serodynamics/preview/pr163
Preview documentation for this PR (at commit 0914ed2)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

repos = "https://cloud.r-project.org",
type = "source",
verbose = TRUE)
withr::local_options(warn = 2)
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation on line 92 is incorrect. It should align with the install.packages call above (3 spaces indentation from the start), not have extra leading whitespace. This will cause the R code to fail with a syntax error.

Copilot uses AI. Check for mistakes.
"command": "npx",
"args": [
"-y",
"@modelcontextprotocol/server-brave-search"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this server archived?

"@modelcontextprotocol/server-filesystem",
"/home/runner/work/serodynamics/serodynamics"
],
"description": "Provides file system access to the serodynamics repository for reading and writing files, searching code, and managing the project structure"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot does this server enable copilot to alter the main branch?

Copy link
Contributor

Copilot AI commented Jan 8, 2026

@d-morrison I've opened a new pull request, #168, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

Comment on lines 92 to 96
withr::local_options(warn = 2)
library(rjags)
library(runjags)
runjags::findJAGS()
runjags::testjags()
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is incorrect. Lines 93-96 should be aligned with the other R commands (lines 88-91). Currently, they have extra leading spaces that make them inconsistent with the surrounding code.

Suggested change
withr::local_options(warn = 2)
library(rjags)
library(runjags)
runjags::findJAGS()
runjags::testjags()
withr::local_options(warn = 2)
library(rjags)
library(runjags)
runjags::findJAGS()
runjags::testjags()

Copilot uses AI. Check for mistakes.
Comment on lines 4 to 7
"r.rterm.windows": "C:\\Program Files\\R\\R-4.1.0\\bin\\R.exe",
"r.rpath.linux": "/usr/bin/R",
"r.rpath.mac": "/usr/local/bin/R",
"r.rpath.windows": "C:\\Program Files\\R\\R-4.1.0\\bin\\R.exe",
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded R version "R-4.1.0" in the Windows path is outdated and too specific. This will break for users who have R 4.2.0 or later installed. Consider using a more flexible path or documenting that users should update this to match their installed R version. A common practice is to use "R\R-4.1.0" as a placeholder with a comment instructing users to update the version number.

Suggested change
"r.rterm.windows": "C:\\Program Files\\R\\R-4.1.0\\bin\\R.exe",
"r.rpath.linux": "/usr/bin/R",
"r.rpath.mac": "/usr/local/bin/R",
"r.rpath.windows": "C:\\Program Files\\R\\R-4.1.0\\bin\\R.exe",
// Update this path to match your installed R version on Windows, e.g. R-4.4.0
"r.rterm.windows": "C:\\Program Files\\R\\R-x.y.z\\bin\\R.exe",
"r.rpath.linux": "/usr/bin/R",
"r.rpath.mac": "/usr/local/bin/R",
// Update this path to match your installed R version on Windows, e.g. R-4.4.0
"r.rpath.windows": "C:\\Program Files\\R\\R-x.y.z\\bin\\R.exe",

Copilot uses AI. Check for mistakes.
Comment on lines +8 to +29
"/home/runner/work/serodynamics/serodynamics"
],
"description": "Provides file system access to the serodynamics repository for reading and writing files, searching code, and managing the project structure"
},
"github": {
"command": "npx",
"args": [
"-y",
"@modelcontextprotocol/server-github"
],
"env": {
"GITHUB_PERSONAL_ACCESS_TOKEN": "${GITHUB_TOKEN}"
},
"description": "Integrates with GitHub for repository operations, issue tracking, pull requests, and workflow management"
},
"git": {
"command": "npx",
"args": [
"-y",
"@modelcontextprotocol/server-git",
"--repository",
"/home/runner/work/serodynamics/serodynamics"
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded repository path "/home/runner/work/serodynamics/serodynamics" is specific to GitHub Actions runner environments and won't work for local development or other CI systems. This path should either be configurable or documented that users need to update it to match their local repository location. Consider using a placeholder like "/path/to/serodynamics" with documentation instructing users to update it, or use environment variable substitution if supported by the MCP implementation.

Copilot uses AI. Check for mistakes.

# Install package dependencies
echo "Installing package dependencies..."
Rscript -e "if (!requireNamespace('pak', quietly = TRUE)) install.packages('pak', repos = 'https://cloud.r-project.org'); pak::local_install_dev_deps(dependencies = TRUE)"
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pak package is installed twice: first in line 38 as part of the development packages array, and then checked again in line 46 with a conditional install. This is redundant. Since pak is already installed in line 38, the conditional check in line 46 is unnecessary and can be simplified to just "pak::local_install_dev_deps(dependencies = TRUE)".

Suggested change
Rscript -e "if (!requireNamespace('pak', quietly = TRUE)) install.packages('pak', repos = 'https://cloud.r-project.org'); pak::local_install_dev_deps(dependencies = TRUE)"
Rscript -e "pak::local_install_dev_deps(dependencies = TRUE)"

Copilot uses AI. Check for mistakes.
@d-morrison
Copy link
Collaborator Author

@copilot open a new pull request to apply changes based on the comments in this thread

Copy link
Contributor

Copilot AI commented Jan 8, 2026

@d-morrison I've opened a new pull request, #169, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits January 8, 2026 06:03
…al Brave Search server

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Address PR review feedback: fix indentation, update configuration paths, replace archived server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants