-
Notifications
You must be signed in to change notification settings - Fork 0
Adding ability to run diagnostic functions on individuals #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Merge commit '4660563dd819748b6850e0b60c2eb51fd3e263e4' #Conflicts: # DESCRIPTION # NEWS.md # tests/testthat/_snaps/plot_jags_effectivedx/typhoid-plot-ess.svg # tests/testthat/_snaps/plot_jags_tracedx/tracedx-typhoid-plot.svg
|
📖 https://ucd-serg.github.io/serodynamics/preview/pr121 |
Codecov Report❌ Patch coverage is
|
Merge commit 'de3b8064e5867dba51e68e89ed7470e90cdeb9ca' #Conflicts: # NEWS.md
Merge branch 'individualdx_2' of https://github.com/UCD-SERG/serodynamics into individualdx_2 # Conflicts: # NEWS.md
|
Hi @Kwan-Jenny , I am having a hard time troubleshooting this one -- I think everything was passing when I first wrote the function but it doesn't seem to be now. Could you take a quick look? We can ask Ezra if we can't figure out the issue. Just as a heads up, when I run the tests on my local Rstudio they all pass. I have also run document() and it doesn't update anything. Thanks a bunch! |
Merge commit '783e92bef4e57e1fa0a000041fe2906346d81e1b'
|
@Kwan-Jenny, thank you for the review! I took most of your suggestions but by the way the function works was not able to combine a few, specifically the one where I combine the stratification and id filter together. Can you take another look when you get a chance? Thanks! |
This pull request will add the ability to run diagnostic functions on individuals using "id" as an input. Apologies for all of the files changed and this relatively big PR -- the same small changes were made across many functions, so I felt it made sense to group it into one PR. A couple of details: