[dev] [Marfuen] mariano/more-ui-pages #2064
Conversation
PR SummaryIntroduces dedicated tabs and UI refinements across vendor pages and risk components.
Written by Cursor Bugbot for commit 882f4fe. This will update automatically on new commits. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| return <div key={`${cert.type}-${index}`}>{iconContent}</div>; | ||
| })} | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
Vendor description removed from display
Medium Severity
The vendor.description text was removed from VendorHeader and is no longer displayed anywhere on the vendor detail page. While a TitleAndDescription component exists that could display it, it's not being used. Users can only access the description through the edit sheet (UpdateTitleAndDescriptionSheet), but there's no read-only view of this information anymore.
| <TabsContent value="tasks"> | ||
| <TaskItems entityId={vendorId} entityType="vendor" organizationId={orgId} /> | ||
| </TabsContent> | ||
| )} |
There was a problem hiding this comment.
TaskItems no longer visible when viewing a task
Medium Severity
The TaskItems component was previously rendered unconditionally on the vendor detail page, making tasks always visible. After this change, TaskItems is wrapped in {!isViewingTask && (...)}, so when isViewingTask is true, the tasks list is no longer accessible. This behavioral regression removes functionality users may rely on when viewing a task in context.
Additional Locations (1)
| }; | ||
|
|
||
| const probabilityLevels = ['Very Likely', 'Likely', 'Possible', 'Unlikely', 'Very Unlikely']; | ||
| const probabilityNumbers = ['5', '4', '3', '2', '1']; |
There was a problem hiding this comment.
Unused constant probabilityLabels left as dead code
Low Severity
The probabilityLabels array constant is defined but never used. The diff shows that the row label element previously had title={probabilityLabels[rowIdx]} for tooltip functionality, but this was removed during the refactoring. The constant definition was left behind, creating dead code that clutters the codebase and may confuse future developers.
| }; | ||
|
|
||
| const probabilityLevels = ['Very Likely', 'Likely', 'Possible', 'Unlikely', 'Very Unlikely']; | ||
| const probabilityNumbers = ['5', '4', '3', '2', '1']; |
There was a problem hiding this comment.
Unused constant impactNumbers is dead code
Low Severity
The impactNumbers array constant is defined but never used anywhere in the component or codebase. While cleaning up probabilityNumbers (which was removed in this PR), this related unused constant was overlooked. It represents dead code that adds unnecessary clutter.
1 participant
This is an automated pull request to merge mariano/more-ui-pages into dev.
It was created by the [Auto Pull Request] action.