-
-
Notifications
You must be signed in to change notification settings - Fork 493
Added Video Generation support for generating images #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I added support for video generation models starting with Wan2.1 models will later extend to more models if this works, currently I added support for WanPipeline in supported model architectures in Image_diffusion plugin but it gives an error where its trying to find /workspace/jobs/None which doesn't exist |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was an issue with running diffusion models, could you update and check if that issue is resolved now? The issue was caused by our new system with the workspace under orgs |
…ab-app into add/video-gen
I figure this is still a WIP but I would also suggest not adding things to the existing image_diffusion plugin and creating a new video diffusion plugin. |
deep1401
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, we might have to restructure the PR and break it down into 2 and test these
| "url": "", | ||
| "files": ["main.py", "video_diffusion_worker.py", "setup.sh"], | ||
| "model_architectures": [ | ||
| "DiffusionPipeline", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no architecture called DiffusionPipeline, this should not be here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also our image_diffusion plugin has no architectures in there so lets also not put any in here.
| @@ -1,0 +1,3 @@ | |||
| #!/bin/bash | |||
| uv pip install git+https://github.com/huggingface/diffusers transformers accelerate safetensors | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version of diffusers is required? The latest release on pypi is 0.35.2 and I assumed Wan2.1 would work with that but maybe you'd know better
| "amd" | ||
| ], | ||
| "files": ["main.py", "diffusion_worker.py", "setup.sh"], | ||
| "model_architectures": ["DiffusionPipeline", "WanPipeline"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think adding architectures here works. Did you try running the model?
You'd need to add architecture in the massive list in the diffusion router
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldnt work because we've not made any frontend changes right? Maybe lets split up PRs and you have a separate WIP for video diffusion. You could implement API and the plugin and add a video for a working model in that PR.
Lets not add anything without testing since diffusion has a lot of things which might break by minor changes here or there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also lets make this PR image_diffusion changes only and also add the ZTurbo model additions in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this works since the structure of the wan model is different. Reference: https://huggingface.co/Wan-AI/Wan2.1-T2V-14B/tree/main
This file in image diffusion was added specifically for FLUX as that required sharding. Lets try to test everything we add :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Currently testing all the things I added. The models are quite huge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay no worries I converted the PR to draft for now and we can split it up and test things.
Let me know if you need my help testing anything or if you dont get something on diffusion about how it works, I can help you figure out!
I mentioned a text to video reference model below but you can look at WanAI's collections and maybe select smaller models for testing. They usually put the small ones in their diffusers collections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Thanks deep. I will try this out and get it done earliest 🫡
| @@ -0,0 +1,3 @@ | |||
| #!/bin/bash | |||
| uv pip install git+https://github.com/huggingface/diffusers transformers accelerate safetensors | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above as to why we need dev version and for what model
deep1401
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I forgot to add this earlier but lets use this as a reference model for Wan support. This feels small enough to run on our hardware and diffusers required version is 0.33.0.dev so just updating to current diffusers prod version should work
https://huggingface.co/Wan-AI/Wan2.1-T2V-1.3B-Diffusers
No description provided.