Fix: add extra handling for cancelling tasks to avoid startup errors #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves startup errors and makes shutting down the API with Ctrl+C more graceful
Context:
While starting the API I was getting unhandled exceptions:
RuntimeError: Task <Task pending name='Task-1487' coro=<ClientCreatorContext.__aexit__()>> got Future <Task pending name='Task-1497' coro=<_wait_for_close()>> attached to a different loopThe issue here seems to be in how we handle the async lifespan, specifically it seems like there are situations where tasks do not get shut down properly.
The change here is simple, basically it makes sure that these processes don't get orphaned with a
finallyclause.Let me know if there are already methods equivalent to _cancel_task/_cancel_tasks.