-
-
Notifications
You must be signed in to change notification settings - Fork 493
Fix the issue of creating buckets for existing teams #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
My main thought here is that maybe there should be a limit on how many teams an org can create? I think this could incur non-neglible S3 charges if it got enough usage |
I think you might be confused here. Each "team" represents a different org. I think this is a separate issue that we need to discuss on Discord. But it would depend on other decisions we take wrt hosting |
| return (0, 0, ["TFL_API_STORAGE_URI is not set"]) | ||
|
|
||
| # Log which provider will be used | ||
| provider = "GCS" if REMOTE_WORKSPACE_HOST == "gcp" else "S3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I know this is just for printing, but I tried changing all my references to "provider" to workspace host or cloud host just to avoid confusion with Cloud Provider meaning SkyPilot/SLURM/etc.
I notice that I did not fully change over all of my comments higher up the code. 👼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Fixes #1121