Skip to content

Conversation

@deep1401
Copy link
Member

@deep1401 deep1401 commented Dec 24, 2025

Fixes #1121

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 7.31707% with 38 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/transformerlab/shared/remote_workspace.py 5.55% 34 Missing ⚠️
api/transformerlab/models/users.py 20.00% 0 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@josh-janes
Copy link
Contributor

My main thought here is that maybe there should be a limit on how many teams an org can create? I think this could incur non-neglible S3 charges if it got enough usage

@deep1401
Copy link
Member Author

My main thought here is that maybe there should be a limit on how many teams an org can create? I think this could incur non-neglible S3 charges if it got enough usage

I think you might be confused here. Each "team" represents a different org. I think this is a separate issue that we need to discuss on Discord. But it would depend on other decisions we take wrt hosting

return (0, 0, ["TFL_API_STORAGE_URI is not set"])

# Log which provider will be used
provider = "GCS" if REMOTE_WORKSPACE_HOST == "gcp" else "S3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I know this is just for printing, but I tried changing all my references to "provider" to workspace host or cloud host just to avoid confusion with Cloud Provider meaning SkyPilot/SLURM/etc.

I notice that I did not fully change over all of my comments higher up the code. 👼

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@deep1401 deep1401 requested a review from dadmobile January 6, 2026 15:31
@deep1401 deep1401 merged commit 92b0637 into main Jan 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't select or create experiments after bucket host change

5 participants