Fixed Keyerror: 'experiment_id' #1099
Conversation
| # Create or update job | ||
| if job_id is None: | ||
| job_id = job_service.job_create( | ||
| type="DOWNLOAD_MODEL", status="STARTED", experiment_id=experiment_id, job_data="{}" |
There was a problem hiding this comment.
I think this is what you said during scrum but every job should have an experiment id associated to itself. Maybe we should try to reproduce the error first?
There was a problem hiding this comment.
Yeah, my guess (at least for the diff above) is that experiment_id isn't getting passed to this function correctly so we should figure out why. I have theories but we should debug to figure out the source for sure!
dadmobile
left a comment
dadmobile
left a comment
There was a problem hiding this comment.
I don't think we should remove experiment_id to solve this problem. Let's first investigate why that isn't getting set in the first place as that might be a sign of some other issue.
We could also consider removing experiment_id from download jobs but only as a separate thing. I seem to remember considering this earlier and we decided it could create problems elsewhere.
|
@dadmobile do you think we can archive this PR for now or is there some root issue we should still fix? |
No description provided.