Skip to content

Fix TODO #396 and #397: safe stream handling & receipt handling #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomusdrw merged 2 commits into from
Oct 24, 2025
Merged

Fix TODO #396 and #397: safe stream handling & receipt handling #740

tomusdrw merged 2 commits into from
Oct 24, 2025

Conversation

@aman879
Copy link
Contributor

@aman879 aman879 commented Oct 24, 2025

  • Added safe handling for block streams in wait_for_confirmations
  • Properly handle None receipt instead of panic in send_transaction_with_confirmation_
  • Uses ok_or_else instead of expect
  • Ensures no panics in production scenarios

tomusdrw
tomusdrw approved these changes Oct 24, 2025
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tomusdrw tomusdrw merged commit 8d889ae into tomusdrw:master Oct 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aman879 @tomusdrw