Fixed accessibility support for "Done" button #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom "bordered" to "done", which has the same effect as setting attributed text style to bold, but leaves accessibility support (increased font sizes!) intact.
Author
|
I now also changed some other labels to support growing fonts for accessibility. This changes the optics slightly as we cannot use fixed size fonts anymore to fully support them, so you might not want to consider these. But at least, use commit 6bcf11d! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched button type from "bordered" to "done", which has the same effect as setting attributed text style to bold, but leaves accessibility support (increased font sizes!) intact.
Additional commit: Updated to latest CocoaPods and Xcode and fixed the version number (Which should be further increased on next submit! - How did you manage to increase the version number at CocoaPods but not in the master podspec file, anyway??)