Add ntfy reporter #854
Merged
Add ntfy reporter #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thp
requested changes
Nov 18, 2025
Owner
thp
left a comment
thp
left a comment
There was a problem hiding this comment.
See comments. Also add an entry for this to CHANGELOG.md in the UNRELEASED section (search for "New reporter" there for examples).
lib/urlwatch/reporters.py
Outdated
| if priority := config_priorities.get(job_state.verb): | ||
| job_headers["Priority"] = priority | ||
| if job_state.job.location_is_url(): | ||
| job_headers['Actions'] = f"view, Open URL, {job_state.job.get_location()}, clear=true".encode('utf-8') |
Owner
There was a problem hiding this comment.
What if job_state.job.get_location() contains , ? Does this value need to be URL-escaped?
Contributor
Author
There was a problem hiding this comment.
Oh, good catch! Values can be quoted with ", so I did that.
Now, I'm not sure if the URL might contain ", of course... If so, the HtmlReporter seems to suffer from this as well, so I'd say this requires a separate fix.
urlwatch/lib/urlwatch/reporters.py
Lines 223 to 233 in 0425631
fyrk
force-pushed
the
add-ntfy-reporter
branch
from
bf73471 to
af5d1ee
Compare
Contributor
Author
|
@thp This should fix the pytest CI :) |
thp
approved these changes
Dec 2, 2025
Owner
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new reporter for ntfy.
Closes #762 (were it not already closed).
It sends one message per job state since I think this aligns best with ntfy's design: It allows to show an "Open URL" action per notification/job.