-
Notifications
You must be signed in to change notification settings - Fork 0
Align documentation with action.yml implementation and add marketplace best practices #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align documentation with action.yml implementation and add marketplace best practices #2
Conversation
…b Marketplace best practices Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
.github/USAGE.md
Outdated
| - uses: thoughtparametersllc/python-testing@v1 | ||
| ``` | ||
| That's it! The action will automatically detect and run your testing frameworks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Change this line because this action does't not automatically detect and run your testing frameworks but assumes you have pytest setup in your code in the directory structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit 7635657. Changed line 30 from "The action will automatically detect and run your testing frameworks" to "The action will install pytest and run your tests".
Also updated similar misleading language in:
- README.md: Changed description from "automatically detect and run Python testing frameworks" to "run Python tests using pytest"
- IMPLEMENTATION_SUMMARY.md: Completely revised to accurately reflect pytest-only implementation
Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
thoughtparametersllc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Will consider this good enough to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR comprehensively updates the documentation to accurately reflect the actual implementation in action.yml. The primary focus is correcting misleading descriptions about "automatic framework detection" and aligning all documentation with the pytest-only implementation currently in action.yml.
Key Changes
- Corrected all references from "automatically detect and run Python testing frameworks" to accurately describe pytest-only implementation
- Added SECURITY.md file following GitHub Marketplace best practices
- Removed documentation for non-existent inputs (unittest-options, nose-options, behave-options, tox-options, generate-badges, update-readme, readme-path, badge-style)
- Fixed inconsistent naming and paths in CONTRIBUTING.md
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SECURITY.md | New comprehensive security policy file with vulnerability reporting guidelines and security best practices |
| .markdownlint.json | New markdown linting configuration for consistent documentation formatting |
| README.md | Updated to accurately reflect pytest-only implementation, corrected input table, removed references to non-existent frameworks and inputs |
| CONTRIBUTING.md | Fixed project name from "Python Linting Action" to "Python Testing Action" and corrected clone path |
| CHANGELOG.md | Restructured with proper versioning and documented all documentation changes in Unreleased section |
| .github/USAGE.md | Removed sections about non-existent frameworks (unittest, nose2, behave, tox, doctest) and updated to reflect pytest-only implementation |
| .github/QUICK_START.md | Updated to reflect actual badge workflow requiring manual insertion and removed references to automatic framework detection |
| .github/IMPLEMENTATION_SUMMARY.md | Updated to accurately reflect pytest-only implementation, removed sections about framework detection logic for non-existent frameworks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/IMPLEMENTATION_SUMMARY.md
Outdated
| ">>>" patterns found in Python files | ||
| ``` | ||
| 2. **Install pytest** - Installs pytest from PyPI | ||
| 3. **Install Requirements** - Installs packages from requirements file if the file exists |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of requirements installation behavior is inaccurate. According to action.yml lines 53-63, the action checks if the requirements file exists and only installs if it exists. It doesn't install "packages from requirements file if the file exists" unconditionally - it first checks if the file exists, and if the file path is specified but the file doesn't exist, it logs a warning but continues. The current description should clarify that requirements are only installed when the file exists at the specified path.
| 3. **Install Requirements** - Installs packages from requirements file if the file exists | |
| 3. **Install Requirements** - Optionally installs packages from a specified requirements file if it exists; if a path is provided but the file is missing, logs a warning and continues without installing |
CHANGELOG.md
Outdated
| ## [1.0.1] - 2025-12-19 | ||
|
|
||
| ## [Unreleased] | ||
| Initial release with pytest support |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version sections 1.0.1 and 1.0.0 both have the same description "Initial release with pytest support", which is inconsistent. Typically, 1.0.0 would be the initial release and 1.0.1 would be a patch release with specific changes. Consider either removing the duplicate entry or providing distinct descriptions for each version to clarify what differentiates 1.0.1 from 1.0.0.
| | **tox** | `tox.ini` file | Testing across multiple Python environments | | ||
| | **doctest** | `>>>` in Python files | Tests embedded in docstrings | | ||
| | Framework | Detection Method | Notes | | ||
| |------------|------------------------------------| --------------------------------------| |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table structure has a formatting issue. Line 19 shows "|------------|------------------------------------| --------------------------------------|" with a space breaking the table structure before the last column separator. This should be "||------------|------------------------------------|------------------------------------|" (all pipes connected without spaces) to maintain proper markdown table formatting.
| |------------|------------------------------------| --------------------------------------| | |
| |------------|------------------------------------|--------------------------------------| |
|
@copilot apply changes based on the comments in this thread |
…uplicate changelog entries Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
Applied all bot review feedback in commit fa8d962:
|
Documentation Update Plan
Summary of Changes
Documentation Accuracy
New Files (GitHub Marketplace Best Practices)
Fixed Issues
Quality Assurance
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.