-
Notifications
You must be signed in to change notification settings - Fork 0
Update documentation to follow GitHub Actions marketplace best practices #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to follow GitHub Actions marketplace best practices #17
Conversation
…ractices Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
…kflows Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
thoughtparametersllc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good enough based on the request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates documentation to align with action.yml specifications and GitHub Actions marketplace best practices. The changes fix parameter naming inconsistencies (underscore to hyphen), add documentation for previously undocumented inputs (commit-badges, badge-directory), and remove references to non-existent workflows.
Key changes:
- Corrected input parameter names from underscore to hyphen format (e.g.,
pylint_options→pylint-options) - Added comprehensive sections including Prerequisites, Outputs, Permissions, Troubleshooting, How It Works, and Best Practices
- Removed all references to non-existent workflows (test-action.yml, security-audit.yml, dependabot.yml)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Fixed parameter naming, documented missing inputs, added marketplace-standard sections, and expanded usage examples with full workflow context |
| .github/WORKFLOW_QUICK_START.md | Removed non-existent workflow references from trigger table and troubleshooting sections, updated descriptions to reflect actual workflows |
| .github/WORKFLOWS.md | Removed documentation for non-existent workflows, updated lint-test.yml description with accurate yamllint rules and formatting checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.md
Outdated
| defaults: | ||
| run: | ||
| working-directory: ./python-service | ||
| permissions: | ||
| contents: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Python Linting | ||
| uses: thoughtparametersllc/python-linting@v1 | ||
| with: | ||
| requirements-file: './python-service/requirements.txt' |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is potentially confusing or incorrect. The defaults.run.working-directory setting only affects run steps, not uses steps (actions). The action will always execute from the repository root, so the requirements-file path is correctly specified as './python-service/requirements.txt'. However, the working-directory setting on lines 322-324 has no effect on the action and may mislead users into thinking it changes the action's working directory. Consider either removing the working-directory setting or adding a clarifying comment that explains the action runs from the repository root and the working-directory only affects shell commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit a689be4. Removed the misleading defaults.run.working-directory setting and added a clarifying comment explaining that the action runs from the repository root regardless of working-directory settings.
README.md
Outdated
| uses: thoughtparametersllc/python-linting@v1 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| commit-badges: 'false' # Only one job should commit badges |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matrix example sets commit-badges: 'false' with the comment "Only one job should commit badges", but this means no job will commit badges since all matrix jobs have it disabled. Consider clarifying the example by either: (1) showing a separate non-matrix job that commits badges, (2) demonstrating conditional badge commits for only one matrix value (e.g., only when python-version == '3.11'), or (3) explaining that badges should be handled in a separate workflow job when using matrix builds.
| commit-badges: 'false' # Only one job should commit badges | |
| commit-badges: "${{ matrix.python-version == '3.11' }}" # Only the Python 3.11 job should commit badges |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: thoughtparametersllc <194255310+thoughtparametersllc@users.noreply.github.com>
Pull Request Details
This provides the basic details of the type, related issues, changes made, and changelog for the given pull request.
Description
Aligned all documentation with action.yml and GitHub Actions marketplace standards. Fixed parameter naming inconsistencies, added missing inputs, removed references to non-existent workflows, and corrected example code based on review feedback.
Type of Change
Changes Made
README.md
pylint_options→pylint-options,black_options→black-options,mypy_options→mypy-optionscommit-badges,badge-directoryworking-directorysetting and added clarifying commentmax-line-lengthto correct[tool.pylint.format]section.github/WORKFLOWS.md
.github/WORKFLOW_QUICK_START.md
Changelog
[Unreleased]sectionTesting
Documentation
Security
Checklist
Additional Notes
Before:
After:
Review Feedback Addressed:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.