WIP: Replicate old Travis CI build in GitHub actions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…execution [`setup.py test` has been deprecated for a while now](https://setuptools.pypa.io/en/latest/deprecated/commands.html#test-build-package-and-run-a-unittest-suite) and `test_dependencies` actually seems to fail on modern Python and setuptools versions. Thus: - Install additional test dependencies from test-requirements.txt - Switch from setup.py test to pytest for running tests - Update README with new testing commands
The used sleekxmpp library is no longer maintained and does not work on any non-EOL version of Python. We might want to switch to using https://codeberg.org/poezio/slixmpp in the future.
We need to account for parallel execution of jobs.
It does not make sense to check formatting separately for each Platform
The dependencies don't install properly in this case
There was a problem hiding this comment.
PR Overview
This PR replicates the old Travis CI build process in GitHub Actions by creating a new CI workflow, updating test instructions in the README, and cleaning up the setup configuration.
- Added a GitHub Actions configuration (.github/workflows/ci.yml) with pip caching and multiple OS support for testing.
- Updated README.md to replace legacy test commands with current pytest instructions.
- Removed obsolete test dependencies and configuration from setup.py and improved config handling in ntfy/config.py.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/ci.yml | New workflow setup replicating Travis CI with pip caching and coveralls integration |
| README.md | Updated test instructions to match current testing practices |
| setup.py | Removed tests_require and test_suite, corrected a typo in long_description |
| ntfy/config.py | Changed configuration handling to copy default configuration |
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
setup.py:21
- Typo found in the long_description; 'mor' should be corrected to 'more'.
long_description = "See the repo readme for mor information"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
It seems the YAPF formatting check was broken for a while and non-conformant formattings snuck in. This reformats the codebase with YAPF.
There was a problem hiding this comment.
PR Overview
This pull request replicates the previous Travis CI build setup using GitHub Actions, while also cleaning up commits and making several formatting improvements across the codebase. Key changes include:
- Introduction of a new CI workflow in .github/workflows/ci.yml to enable pip caching, Windows builds, and Coveralls integration.
- Updates to the README to reflect changes in how the tests are run.
- Various formatting and style improvements across multiple modules.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/ci.yml | New GitHub Actions CI configuration with jobs for formatting, testing, and finishing steps. |
| README.md | Updated testing instructions to use pytest instead of setup.py test. |
| ntfy/cli.py, ntfy/config.py, etc. | Formatting and parameter list adjustments for clarity and consistency. |
| setup.py | Removal of legacy test dependencies and test suite definitions. |
| Various files in ntfy/backends/* | Formatting improvements and minor refactorings in backend notifier implementations. |
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
setup.py:17
- The removal of tests_require and test_suite in setup.py might affect legacy test discovery workflows; please ensure that the updated testing instructions in the README fully cover the intended test setup and that users are aware of this migration.
test_deps = ['mock', 'sleekxmpp', 'emoji', 'psutil']
Owner
Author
|
This was just a draft for dschep#277. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open items: