Removed oneOf annotations for Search Payloads #3660
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommylau523
changed the title
sgrimm
approved these changes
Nov 24, 2025
Contributor
|
I believe the mobile app uses the search API too. |
Contributor
Author
I am making a change in the FE typegen script to make sure it doesn't change what existing. It is functional with some slight script changes but our FE code uses the overridden types so it will require some work there as well. |
tommylau523
added a commit
to terraware/terraware-web
that referenced
this pull request
Dec 3, 2025
These types are generated with this fix applied: terraware/terraware-server#3660 The generation step for Search API is temporarily commented out in order to not overwrite the correct types. Search API are POSTs and therefore mutations by default, and will not be cached as a result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will results in correct OpenAPI doc. This will also allow for correct type generation in the FE without circular references.
The
openapi-tspackage used in the FE still has a bug that requires manual overwrite. That script will be updated at the same time as this PR to ensure correctness.