Skip to content

Conversation

@bigbes
Copy link
Collaborator

@bigbes bigbes commented Dec 17, 2025

  • generator to generate needed key-values
  • validator to validate existing key-values
  • removed gocognit/funlen from list of linters, disabled revive check
  • implemented typed marshaller, removed old one

Part of TNTP-4191

@coveralls
Copy link

coveralls commented Dec 17, 2025

Pull Request Test Coverage Report for Build 20334578531

Details

  • 363 of 373 (97.32%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.4%) to 32.392%

Changes Missing Coverage Covered Lines Changed/Added Lines %
marshaller/typed.go 15 17 88.24%
integrity/validator.go 118 121 97.52%
integrity/generator.go 54 59 91.53%
Totals Coverage Status
Change from base Build 20228710580: 7.4%
Covered Lines: 1135
Relevant Lines: 3504

💛 - Coveralls

@bigbes bigbes force-pushed the bigbes/TNTP-4191-integrity-generator branch from eaeac84 to 517e114 Compare December 17, 2025 12:48
Copy link
Contributor

@patapenka-alexey patapenka-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bigbes bigbes force-pushed the bigbes/TNTP-4191-integrity-generator branch 3 times, most recently from 5baf9d9 to 391d93f Compare December 18, 2025 10:14
@bigbes bigbes requested a review from oleg-jukovec December 18, 2025 10:23
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are red.

* generator to generate needed key-values
* validator to validate existing key-values
* removed gocognit/funlen from list of linters, disabled revive check
* implemented typed marshaller, removed old one

Part of TNTP-4191
@bigbes bigbes force-pushed the bigbes/TNTP-4191-integrity-generator branch from 391d93f to 2c44171 Compare December 18, 2025 10:54
@bigbes bigbes requested a review from oleg-jukovec December 18, 2025 10:55
@bigbes bigbes merged commit 9b1f6ea into master Dec 18, 2025
14 checks passed
@bigbes bigbes deleted the bigbes/TNTP-4191-integrity-generator branch December 18, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants