[Platform] Remove unused code in Vector constructor and add missing tests #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilleislasse
requested review from
OskarStark and
chr-hertel
as code owners
carsonbot
added
Platform
carsonbot
changed the title
chr-hertel
approved these changes
Dec 14, 2025
Member
|
Good catch, thanks @camilleislasse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Vectorconstructor had duplicate validation code. The second check (line 36-38) could never be reached because the first check (line 28-30) already handles the same condition.Given
$dimensionsis typed?int:null !== $dimensions= "dimensions is not null"\is_int($dimensions)= "dimensions is an int"When
$dimensionsis not null, it is an int. So both conditions are equivalent, making the second check unused code.This PR: