Show progress for package description tasks on activation #1997
+442
−247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
The `swift package show-dependencies` and `swift package describe` commands run on extension activation, and several extension features are gated behind their results. These were run with `execSwift` calls which show no progress in the VS Code UI. The `swift package show-dependencies` command specifically could kick off a package resolution if the dependencies are missing, and for large packages this could take quite some time. As a result the extension could look like it was not activating. Move these two commands into VS Code tasks that report their status in the progress bar, and let the user see the actual commands being run in the terminal.
plemarquand
force-pushed
the
show-dep-startup-progress-2
branch
from
77907f4 to
6f89ae8
Compare
plemarquand
force-pushed
the
show-dep-startup-progress-2
branch
from
76bb85b to
e43da0c
Compare
plemarquand
force-pushed
the
show-dep-startup-progress-2
branch
4 times, most recently
from
0bb0b40 to
6a18d7e
Compare
plemarquand
force-pushed
the
show-dep-startup-progress-2
branch
from
6a18d7e to
38358ae
Compare
This reverts commit 26e7b86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
swift package show-dependenciesandswift package describecommands run on extension activation, and several extension features are gated behind their results. These were run withexecSwiftcalls which show no progress in the VS Code UI.The
swift package show-dependenciescommand specifically could kick off a package resolution if the dependencies are missing, and for large packages this could take quite some time. As a result the extension could look like it was not activating.Move these two commands into VS Code tasks that report their status in the progress bar, and let the user see the actual commands being run in the terminal.
Tasks
[ ] Documentation has been updated