Don’t print module selectors in more cases + Disable preserve-types when using module selectors #86135
+102
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
requested review from
hborla,
slavapestov,
tshortli and
xedin
as code owners
Contributor
Author
|
@swift-ci please smoke test |
slavapestov
reviewed
Dec 19, 2025
lib/AST/ASTPrinter.cpp
Outdated
| parent = generic->getParent(); | ||
| return parent && parent->isTypeParameter(); | ||
| else if (auto dmt = T->getAs<DependentMemberType>()) | ||
| parent = dmt->getBase(); |
Contributor
There was a problem hiding this comment.
The base of a DependentMemberType should always be a type parameter, so you can just return true here without recursing
nkcsgexi
approved these changes
Dec 19, 2025
There were a number of cases where Swift would emit module selectors into module interface files that it was subsequently unable to parse because the compiler at least temporarily represented them as dependent member types. Modify the carve-out so that if *any* of a type’s parents are generic parameters or archetypes, we don’t print a module selector on it. Fixes rdar://166180424.
beccadax
force-pushed
the
mod-squad-independent
branch
from
d09c47f to
817821a
Compare
The old `-module-interface-preserve-types-as-written` workaround flag prevents module selectors from being printed into module interfaces even when they have been explicitly requested. Disable it and emit a warning when it’s used in combination with `-enable-module-selectors-in-module-interface`. Fixes rdar://166237384.
beccadax
force-pushed
the
mod-squad-independent
branch
from
817821a to
ad77857
Compare
beccadax
changed the title
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of cases where Swift would emit module selectors into module interface files that it was subsequently unable to parse because the compiler at least temporarily represented them as dependent member types. Modify the carve-out so that if any of a type’s parents are generic parameters or archetypes, we don’t print a module selector on it.
Fixes rdar://166180424.
The old
-module-interface-preserve-types-as-writtenworkaround flag prevents module selectors from being printed into module interfaces even when they have been explicitly requested. Disable it and emit a warning when it’s used in combination with-enable-module-selectors-in-module-interface.Fixes rdar://166237384.
(These have been rolled into a single PR because the test changes intersect.)