[CSDiagnostics] Produce a tailored diagnostic for key path mutability mismatches #86134
+87
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mismatches If the type of a key path literal is read-only due to setter availability constraints but the context requires a writable key path, let's produce a tailed availability diagnostic that points to the offending setter. Resolves: rdar://157249275
…k fails This helps to propagate types bi-directionally and avoid extraneous failures related to generic parameter inference when the real issue is mutability or type erasure.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS platform |
Contributor
Author
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type of a key path literal is read-only due to setter
availability constraints but the context requires a writable
key path, let's produce a tailed availability diagnostic that
points to the offending setter.
Also match root/value of a key path even when superclass
check fails to propagate types and avoid extraneous issues
with generic parameter inference when the problem is related
to key path mutability or erasure.
Resolves: rdar://157249275