Skip to content

Test: disable flaky bit of manual_ownership.swift #86117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kavon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test: disable flaky bit of manual_ownership.swift #86117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions test/SIL/manual_ownership.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,13 +423,24 @@ extension FixedWidthInteger {
}
}

struct CollectionOf32BitLittleEndianIntegers<BaseCollection: Collection> where BaseCollection.Element == UInt8 {
var baseCollection: BaseCollection

init(_ baseCollection: BaseCollection) {
precondition(baseCollection.count % 4 == 0)
self.baseCollection = baseCollection // expected-warning {{accessing 'baseCollection' may produce a copy}}
} // expected-warning {{accessing 'self' may produce a copy}}
// FIXME(rdar://164852821): Some of the diagnostic message tailoring for assignments
// are unstable when targeting platforms like the simulator, since we seem to emit
// slightly different SIL which then throws off the heuristics. For example,
//
// <snip>/swift/test/SIL/manual_ownership.swift:431:68: error: incorrect message found
// self.baseCollection = baseCollection
// // x-warning@-1 {{accessing 'baseCollection' may produce a copy}}
// ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// closure capture of 'baseCollection' requires independent copy of it; write [baseCollection = copy baseCollection] in the closure's capture list to acknowledge
//

// FIXME: the above initializer shouldn't have any diagnostics
}
// struct CollectionOf32BitLittleEndianIntegers<BaseCollection: Collection> where BaseCollection.Element == UInt8 {
// var baseCollection: BaseCollection
//
// init(_ baseCollection: BaseCollection) {
// precondition(baseCollection.count % 4 == 0)
// self.baseCollection = baseCollection // x-warning {{accessing 'baseCollection' may produce a copy}}
// } // x-warning {{accessing 'self' may produce a copy}}
//
// // FIXME: the above initializer shouldn't have any diagnostics
// }