[DependencyScan] Correct setup clang VFS for dependency scanning #86104
+188
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
Xazax-hun,
artemcm,
beccadax,
egorzhdan,
ian-twilightcoder,
j-hui,
susmonteiro and
tshortli
as code owners
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
0ff27f8 to
57c160f
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
57c160f to
f359367
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
f359367 to
9971051
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
9971051 to
b0123c7
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
b0123c7 to
31c7be3
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
31c7be3 to
d61b7d9
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
d61b7d9 to
3741260
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
3741260 to
9003f5f
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
9003f5f to
561cb41
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
561cb41 to
81d84c1
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
81d84c1 to
0c4b596
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
0c4b596 to
d2bc03e
Compare
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
d2bc03e to
dcd7af3
Compare
Contributor
Author
|
@swift-ci please smoke test |
Currently, dependency scanner is not reporting the redirecting files that are baked inside swift-frontend for platform support. This causes dependency scanner returns virtual path for those files, and swift-driver/build-system will not be able to correct validate the files on incremental build, causing incremental build to be almost clean builds. This behavior issue is caused by the dependency scanning file system layer inside clang dependency scanner that caches stats. If the redirecting files are created underneath the layer, the real path is lost. This fixes the issue by moving the redirecting files above the caching layer using `-ivfsoverlay` option. In addition to that, this commit also unifies how clang importer and clang dependency scanner initiate the VFS, making the logic much simpler.
cachemeifyoucan
force-pushed
the
eng/PR-clang-importer-vfs
branch
from
dcd7af3 to
35d8d1a
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, dependency scanner is not reporting the redirecting files that are baked inside swift-frontend for platform support. This causes dependency scanner returns virtual path for those files, and swift-driver/build-system will not be able to correct validate the files on incremental build, causing incremental build to be almost clean builds.
This behavior issue is caused by the dependency scanning file system layer inside clang dependency scanner that caches stats. If the redirecting files are created underneath the layer, the real path is lost. This fixes the issue by moving the redirecting files above the caching layer using
-ivfsoverlayoption.In addition to that, this commit also unifies how clang importer and clang dependency scanner initiate the VFS, making the logic much simpler.