Skip to content

WIP: Fix output stream inconsistency in swiftbuild #9529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
PhantomInTheWire wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Draft

WIP: Fix output stream inconsistency in swiftbuild #9529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Sources/Commands/SwiftBuildCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,24 @@ public struct SwiftBuildCommand: AsyncSwiftCommand {
productsBuildParameters: BuildParameters,
toolsBuildParameters: BuildParameters
) async throws {
// Create stdout-based observability for build output consistency.
// All build output (progress and errors/diagnostics) should go to stdout for "swift build".
let buildOutputObservability = SwiftCommandObservabilityHandler(
outputStream: TSCBasic.stdoutStream,
logLevel: swiftCommandState.logLevel,
colorDiagnostics: swiftCommandState.options.logging.colorDiagnostics
)
let buildObservabilitySystem = ObservabilitySystem(buildOutputObservability)

let buildSystem = try await swiftCommandState.createBuildSystem(
explicitProduct: options.product,
shouldLinkStaticSwiftStdlib: options.shouldLinkStaticSwiftStdlib,
productsBuildParameters: productsBuildParameters,
toolsBuildParameters: toolsBuildParameters,
// command result output goes on stdout
// ie "swift build" should output to stdout
outputStream: TSCBasic.stdoutStream
outputStream: TSCBasic.stdoutStream,
observabilityScope: buildObservabilitySystem.topScope
)
do {
try await buildSystem.build(subset: subset, buildOutputs: [])
Expand Down