Fix stack overflow in macro namespace lookups #992
+45
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Convert recursive namespace lookups to iteration to prevent stack overflow when building projects with many targets.
pepicrft
force-pushed
the
fix/macro-namespace-stack-overflow
branch
from
6496f02 to
e237e73
Compare
Collaborator
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building projects with many targets using the swiftbuild backend, the process crashes with a stack overflow. The teco project, which has 522 targets, is an example of this.
The
lookupMacroDeclarationandlookupConditionParametermethods traverse parent namespaces recursively. With hundreds of nested namespaces, this blows the call stack.This PR converts those recursive lookups to iterative ones using a while loop, which can handle any depth.
Fixes swiftlang/swift-package-manager#9270