Skip to content

feat: type currentTarget in on function #17370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 5 commits into from
Dec 22, 2025
+15 −8
Merged

feat: type currentTarget in on function #17370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d3bd05
feat: type `currentTarget` in `on` function
that-richan Dec 16, 2025
be6e664
`EventTarget &` is redundant, `Element` already extends `EventTarget`
Rich-Harris Dec 22, 2025
bebdb84
no need for optional chaining
Rich-Harris Dec 22, 2025
03843b7
add currentTarget for other overloads
Rich-Harris Dec 22, 2025
4f4cb94
update changeset
Rich-Harris Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bumpy-radios-live.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: type `currentTarget` in `on` function
8 changes: 4 additions & 4 deletions packages/svelte/src/events/public.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
export function on<Type extends keyof WindowEventMap>(
window: Window,
type: Type,
handler: (this: Window, event: WindowEventMap[Type]) => any,
handler: (this: Window, event: WindowEventMap[Type] & { currentTarget: Window }) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand All @@ -19,7 +19,7 @@ export function on<Type extends keyof WindowEventMap>(
export function on<Type extends keyof DocumentEventMap>(
document: Document,
type: Type,
handler: (this: Document, event: DocumentEventMap[Type]) => any,
handler: (this: Document, event: DocumentEventMap[Type] & { currentTarget: Document }) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand All @@ -30,7 +30,7 @@ export function on<Type extends keyof DocumentEventMap>(
export function on<Element extends HTMLElement, Type extends keyof HTMLElementEventMap>(
element: Element,
type: Type,
handler: (this: Element, event: HTMLElementEventMap[Type]) => any,
handler: (this: Element, event: HTMLElementEventMap[Type] & { currentTarget: Element }) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand All @@ -41,7 +41,7 @@ export function on<Element extends HTMLElement, Type extends keyof HTMLElementEv
export function on<Element extends MediaQueryList, Type extends keyof MediaQueryListEventMap>(
element: Element,
type: Type,
handler: (this: Element, event: MediaQueryListEventMap[Type]) => any,
handler: (this: Element, event: MediaQueryListEventMap[Type] & { currentTarget: Element }) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand Down
2 changes: 2 additions & 0 deletions packages/svelte/tests/types/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ on(window, 'click', (e) => e.button);

on(document, 'click', (e) => e.button);

on(document.createElement('input'), 'input', (e) => e.currentTarget.value);

on(
document.body,
'clidck',
Expand Down
8 changes: 4 additions & 4 deletions packages/svelte/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2801,7 +2801,7 @@ declare module 'svelte/events' {
export function on<Type extends keyof WindowEventMap>(
window: Window,
type: Type,
handler: (this: Window, event: WindowEventMap[Type]) => any,
handler: (this: Window, event: WindowEventMap[Type] & { currentTarget: Window }) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand All @@ -2812,7 +2812,7 @@ declare module 'svelte/events' {
export function on<Type extends keyof DocumentEventMap>(
document: Document,
type: Type,
handler: (this: Document, event: DocumentEventMap[Type]) => any,
handler: (this: Document, event: DocumentEventMap[Type] & { currentTarget: Document }) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand All @@ -2823,7 +2823,7 @@ declare module 'svelte/events' {
export function on<Element extends HTMLElement, Type extends keyof HTMLElementEventMap>(
element: Element,
type: Type,
handler: (this: Element, event: HTMLElementEventMap[Type]) => any,
handler: (this: Element, event: HTMLElementEventMap[Type] & { currentTarget: Element }) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand All @@ -2834,7 +2834,7 @@ declare module 'svelte/events' {
export function on<Element extends MediaQueryList, Type extends keyof MediaQueryListEventMap>(
element: Element,
type: Type,
handler: (this: Element, event: MediaQueryListEventMap[Type]) => any,
handler: (this: Element, event: MediaQueryListEventMap[Type] & { currentTarget: Element }) => any,
options?: AddEventListenerOptions | undefined
): () => void;
/**
Expand Down
Loading