chore: co-locate image assets in template

[sacrosanctic]

closes #859

In addition:

• add comment explaining why svelte.config.ts isn't used
• minor typos and fixes

I've grouped relevant changes together for easy git revert.

[changeset-bot]

⚠️ No Changeset found

Latest commit: df9037a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@860

npx https://pkg.pr.new/sveltejs/cli/sv@860

commit: df9037a

[jycouet]

Suggested change

	// ecosystem doesn't support `svelte.config.ts` https://github.com/sveltejs/cli/issues/816#issuecomment-3568032867
	// but the user may have opt in to it
	// `sv` uses `svelte.config.js` by default
	// but users may have changed to `svelte.config.ts`

[jycouet]

Hi @sacrosanctic, thx for looking at this.

I'll try to organize feedback ^^

A/ colocate assets

• After this, there is nothing in lib folder and we do'nt show $lib alias that is a nice default
• there is a ton of files directly under /routes and it's not that pretty. (subjective)
• what about a (home) level? in order to:
  • have less stuff just under /routes
  • show organization folder

• what about keeping svelte-logo.svg in lib/images and use it in Header.svelte and as favicon as well?

I'm not 100% sure we want all this, but I would look into this direction if there is something to change.
Maybe @benmccann has more opinion on this?

B/ consistent names
Is it way more consistent? 😅

• just before it's xxxTS
• this is tsXxx
• just after it's xxx without the js

C/ easier to read
I remember not linking writing this, haha.

D/ use commonFilePaths
Looks good 👍

E/ comment on no ecosystem support for svelte.config.ts
I'm not a big fan of the 3 mentions & link to github comment. I would put something like my suggestion and remove the 2 other places

F/ typo
Thank you 😁 🫣

[sacrosanctic]

I figured there would be a discussion about the assets, so I opened an issue for it. I guess it doesn't matter where the discussion happens.

what about a (home) level?

I've personally used /FILES before, it would be nice to come up with an agreeable convention.

[benmccann]

Maybe _assets if we want to put just the images and .css there or perhaps _includes for everything including those and the components. I asked in #ambassadors to see if others have ideas