Skip to content

Conversation

@grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Dec 16, 2025

Description

This PR adds support for custom query parameters in the download method of the storage client.

Changes

  • Added optional queryParams parameter to the download method in StorageFileApi
  • Query parameters are merged with transform query parameters (if any)
  • Added test case to verify query params are correctly passed to the request
  • Enhanced CustomHttpClient test helper to track received requests and make status code configurable

Testing

  • Added unit test should download public file with query params that verifies query parameters are correctly included in the download request

Example Usage

final response = await client
    .from('public_bucket')
    .download('b.txt', queryParams: {'version': '1'});

- Add optional queryParams parameter to download method
- Merge queryParams with transform query parameters
- Add test case for download with query params
- Enhance CustomHttpClient to track received requests
@grdsdev grdsdev requested a review from Vinzent03 December 16, 2025 19:24
@grdsdev grdsdev requested a review from a team December 17, 2025 14:12
@coveralls
Copy link

coveralls commented Dec 17, 2025

Pull Request Test Coverage Report for Build 20305880890

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 79.933%

Totals Coverage Status
Change from base Build 20270238886: 0.004%
Covered Lines: 3362
Relevant Lines: 4206

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants