Feature branch #1361
Open
Feature branch #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original _exportDate function called `date.split('-')` before validating the format of the date string. This could lead to `month` or `day` variables being `undefined` if the date string was not in the expected format.
Passing `undefined` to the XML element's `append` method likely caused a runtime error, preventing the XML from being generated.
This commit refactors the function to only parse the year, month, and day from the date string after the string has been successfully validated against a corresponding format (YYYY-MM-DD, YYYY-MM, or YYYY). This prevents runtime errors from invalid date formats during XML export.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Please describe why you are suggesting the PR.
What
Elaborate what your changes do, and how they address the problem described.