Skip to content

Conversation

@elelaysh
Copy link
Contributor

@elelaysh elelaysh commented Dec 5, 2025

WIP

@elelaysh elelaysh requested a review from a team as a code owner December 5, 2025 16:41
@elelaysh elelaysh marked this pull request as draft December 5, 2025 16:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Rocky Linux 9.7 by updating various configuration files. The changes include updating the default Rocky Linux minor version, adding new repository versions for 9.7, and adjusting DOCA version handling. My review focuses on improving maintainability and correcting potential errors in the configuration. I've pointed out a hardcoded branch reference that should be made more generic, a misleading comment, and a likely invalid CVE identifier in the Trivy allowlist.

@elelaysh elelaysh force-pushed the rl-9.7 branch 2 times, most recently from 31bc446 to 5a7be0c Compare December 8, 2025 09:08
elelaysh and others added 3 commits December 22, 2025 19:46
- DOCA 3.2.1 for RL 9.7
- Bump Rocky 9 Security SIG repo, add source
The modules path remains specific to minor releases.
stackhpc_pulp_repo_doca_2_9_3_rhel9_6_modules_version: 20250714T141841
stackhpc_pulp_repo_doca_3_2_0_rhel9_version: 20251204T124815
stackhpc_pulp_repo_doca_3_2_1_rhel9_version: 20251219T132023
stackhpc_pulp_repo_doca_3_2_1_rhel9_7_modules_version: 20251222T160623
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we expecting to create a new variable with every minor release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants