Synchronise master with upstream #236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables updates to health_status and health_status_reason during states CREATE_IN_PROGRESS, DELETE_IN_PROGRESS, and their _FAILED counterparts. Change-Id: Icca99a9b8103b52ed76e03f0834d0ff26a4899d2
This is a style-only change to make a coming change easier to review. Change-Id: Ifc746821ddd2070d2cb6a01be50a07f5053f3009 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Per the webob docs [1], 'host_url' returns the URL of the host rather than the URL of the application (which is the URL of the host plus the 'SCRIPT_NAME' [2] portion of the path). This means if you deploy Magnum under a path, like DevStack now does, you are missing part of the path. Correct this by using 'application_url' instead, like Nova [3] and other projects already do. Note that this is compliant with the version discovery guidelines, which indicate that absolute paths can be consumed wholesale [4]. [1] https://docs.pylonsproject.org/projects/webob/en/stable/index.html#urls [2] https://peps.python.org/pep-3333/ [3] https://opendev.org/openstack/nova/src/commit/64ca204c9cf497b0dcfff2d3a24b0dd795a57d1d/nova/api/openstack/common.py#L389-L414 [4] https://specs.openstack.org/openstack/api-sig/guidelines/consuming-catalog/version-discovery.html#expanding-endpoints Change-Id: I42da06cd1b04e05ac2c4224c06992ba630854fac Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Closes-bug: #2083168
Mock utcnow is useful for testing operations [1] that should not change the `updated_at` value. For tests that do not validate `updated_at`, there is really no need for such a mock. Clean up unused mock to simplify the code. [1] https://opendev.org/openstack/magnum/src/tag/21.0.0/magnum/tests/unit/api/controllers/v1/test_cluster.py#L324 Change-Id: Ibbbe92a4e27a46438ee231fe4a314122dcabc57a Signed-off-by: Jake Yip <jake.yip@ardc.edu.au>
Update the 2024.1 release notes configuration to build from unmaintained/2024.1. Change-Id: I896df54b5577b4fed0b737523432e977c648a247 Signed-off-by: OpenStack Release Bot <infra-root@openstack.org> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/change_reno_branch_to_unmaintained.sh
Change-Id: I89ae6562e8693f8d5be89ce199f181b5882958c1 Signed-off-by: okozachenko <okozachenko1203@gmail.com>
github-actions
bot
added
automated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of master from upstream master.