Skip to content

Conversation

@Deepesh8122
Copy link

Description

Added support for HTML button elements in PDF generation with full styling capabilities and proper attribute handling.

Key Features

  • ✨ Complete button tag implementation with default styling
  • 🎨 Support for custom CSS properties and classes
  • ✅ Comprehensive test coverage
  • 🔍 Proper style inheritance and reset handling

Technical Details

  • Implemented Button class extending AbstractTag
  • Added default button styling (background, border, padding)
  • Handles common button attributes (type, class, id)
  • Includes style management system
  • Added unit tests covering core functionality

Test Coverage

ButtonTest Results:
✓ Button name validation
✓ Button properties handling
✓ Style inheritance
✓ Custom class support

@spipu spipu merged commit d2d9e78 into spipu:master Apr 25, 2025
0 of 8 checks passed
@spipu
Copy link
Owner

spipu commented Apr 25, 2025

it is not working, i revert all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants