Skip to content

Conversation

@alesan99
Copy link
Contributor

Fixes #7641

Speeds up default tree creation significantly.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Test with the setup page
    • Use a blank database
    • Pre-load all the trees you can and complete the setup
    • Make sure the trees were pre-loaded correctly.
  • Test in the taxon tree viewer
    • Add a new taxon tree and choose to import a populated one.
    • Make sure the tree was created correctly. An easy way to check is to compare it with the same tree created before the speed ups.

Testing instructions from the issue-7593 PR to check:

  • Guided Setup on a blank database
  • Use a blank DB to test this PR.
  • Configure ranks for the geography and taxon trees.
  • Test the new pre-load tree check box for geography.
  • After the setup, make sure the default tree creation process started for the trees you selected to pre-load. (You will see notifications)
    • If you chose a paleo/geo database then a chronostrat tree should also be imported automatically.
  • The taxon tree that was created should not have a root node.
  • After the setup, check all the new trees, make sure the ranks respect your configuration.
  • Configuration tool and existing trees
  • Creating a new discipline with the configuration tool should create an empty taxon tree.
  • An empty taxon tree should have an import button
  • Make sure you can import a taxon tree into the existing empty tree
  • Make sure you can still create a new populated tree

@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Jan 23, 2026
@alesan99 alesan99 changed the base branch from main to issue-7593 January 23, 2026 14:05
@alesan99 alesan99 marked this pull request as ready for review January 23, 2026 15:51
@CarolineDenis
Copy link
Contributor

CarolineDenis commented Jan 23, 2026

Storage Tree:

  • Change separator from to ,
  • Building, Collection, Room, Aisle need to have full name checked

Taxon Tree:

  • Subspecies check Is full name needs to be removed
  • Preload tree is back, normal? (It works)
  • Ranks added in the setup but not included by default (i.e Subphylum) are not included in the generated tree (Which makes sense when we think about it)
  • Ranks cannot be deleted ('cannot delete root level tree definition item')
    ==> Notes: The above issues will not have to be addressed. We are going to simplify the implementation. See section simplification below.

Geography Tree:

  • County, State and Country need to have full name checked

Working:

  • Geography tree is loaded and respects the configuration made during the setup
  • Storage tree is created and respects the configuration made during the setup
  • Ranks removed in the setup that were included by default (i.e Genus) are not included in the generated tree, changes are reflected
  • Taxon tree is loaded with the correct taxon tree
  • Creating an empty tree in the tree viewer works and respects the rank config
  • Loading a tree in the tree viewer works and respects the ranks
  • Creating a new discipline with a collection in the system config creates a default empty tree
  • Loading the tree creating during the creation of the new discipline in system config works

Simplifications:

For the taxon tree configuration in the setup, some simplifications will be introduced.
The updated flow will be as follows:

  • The user selects the discipline type and name.
  • The user chooses whether or not to load a taxon tree (via a simple checkbox).
  • All taxon tree customization options are removed from the setup process.
  • Once in Specify 7, the user can access the Tree Viewer to make any desired configuration changes or remove ranks as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

[Guided Setup] : Speed up default tree creation

3 participants