Skip to content

Conversation

@agologan
Copy link
Contributor

@agologan agologan commented Nov 4, 2025

Use Go v1.25 toolchain to build the service on top of the latest debian 13 release.

This change also upgrades golangci-lint to v2.7.2 which is required for Go 1.25 but does not aim to resolve the 34 issues found.
29x Error return value of <func> is not checked
3x ST1005: error strings should not be capitalized
2x QF1004: could use strings.ReplaceAll instead

@agologan agologan force-pushed the go-1.25 branch 2 times, most recently from 4d167cf to e0bae48 Compare December 10, 2025 11:14
@sosedoff
Copy link
Owner

@agologan the Dockerfile changes here are failing. This is what i got when i ran make docker:

4.451 E: Package 'netcat' has no installation candidate
------
Dockerfile:37
--------------------
  36 |     COPY --from=keyring /keyring.pgp $keyring
  37 | >>> RUN . /etc/os-release && \
  38 | >>>     echo "deb [signed-by=${keyring}] http://apt.postgresql.org/pub/repos/apt/ ${VERSION_CODENAME}-pgdg main" > /etc/apt/sources.list.d/pgdg.list && \
  39 | >>>     apt-get update && \
  40 | >>>     apt-get install -qq --no-install-recommends ca-certificates openssl netcat curl postgresql-client
  41 |
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c . /etc/os-release &&     echo \"deb [signed-by=${keyring}] http://apt.postgresql.org/pub/repos/apt/ ${VERSION_CODENAME}-pgdg main\" > /etc/apt/sources.list.d/pgdg.list &&     apt-get update &&     apt-get install -qq --no-install-recommends ca-certificates openssl netcat curl postgresql-client" did not complete successfully: exit code: 100
make: *** [docker] Error 1

@sosedoff
Copy link
Owner

Proposed change:

diff --git a/Dockerfile b/Dockerfile
index 7f3cf5a..229ee56 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -37,7 +37,7 @@ COPY --from=keyring /keyring.pgp $keyring
 RUN . /etc/os-release && \
     echo "deb [signed-by=${keyring}] http://apt.postgresql.org/pub/repos/apt/ ${VERSION_CODENAME}-pgdg main" > /etc/apt/sources.list.d/pgdg.list && \
     apt-get update && \
-    apt-get install -qq --no-install-recommends ca-certificates openssl netcat curl postgresql-client
+    apt-get install -qq --no-install-recommends ca-certificates openssl netcat-openbsd curl postgresql-client
 
 COPY --from=build /build/pgweb /usr/bin/pgweb

@agologan
Copy link
Contributor Author

Thank you, not sure how I missed that.
We could add a pull_request trigger in docker.yml to check for it.

@sosedoff sosedoff merged commit 16f88a1 into sosedoff:main Dec 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants