Skip to content

Extend Trigger Capability for Event ACKing #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DylanTinianov wants to merge 47 commits into
base: main
Choose a base branch
from
Open

Extend Trigger Capability for Event ACKing #1736

DylanTinianov wants to merge 47 commits into from

Conversation

@DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Dec 15, 2025 •
edited
Loading

Extends Trigger Capabilities to support trigger event ACKing.

EPIC Guaranteed Trigger Delivery

  • Extends Capabilities API with AckEvent
  • Implements BaseTriggerCapability to handle event persistence, ACKing, and resending.
  • Extends protos and grpc client/ server for TriggerExecutable to call AckEvent

Supports

Trigger Capability Event ACKs chainlink

@DylanTinianov DylanTinianov self-assigned this Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025 •
edited
Loading

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (8)

pkg/capabilities.TriggerExecutable (1)
  • AckEvent — ➕ Added
pkg/capabilities/pb.TriggerExecutableClient (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/chain-capabilities/evm/server.ClientCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/chain-capabilities/solana/server.ClientCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/protoc/pkg/test_capabilities/actionandtrigger/server.BasicCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/protoc/pkg/test_capabilities/basictrigger/server.BasicCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/triggers/cron/server.CronCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/triggers/http/server.HTTPCapability (1)
  • AckEvent — ➕ Added

📄 View full apidiff report

@DylanTinianov DylanTinianov changed the title Create BaseTriggerCapability Extend Trigger Capability API with Acks Dec 15, 2025
@DylanTinianov DylanTinianov mentioned this pull request Dec 15, 2025
Open
@DylanTinianov DylanTinianov changed the title Extend Trigger Capability API with Acks Extend Trigger Capability Dec 24, 2025
@DylanTinianov DylanTinianov changed the title Extend Trigger Capability Extend Capabilities Dec 24, 2025
@DylanTinianov DylanTinianov marked this pull request as ready for review January 30, 2026 21:43
@DylanTinianov DylanTinianov requested review from a team as code owners January 30, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MStreet3 MStreet3 Awaiting requested review from MStreet3

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@Unheilbar Unheilbar Awaiting requested review from Unheilbar

@bolekk bolekk Awaiting requested review from bolekk

@fernandezlautaro fernandezlautaro Awaiting requested review from fernandezlautaro

At least 2 approving reviews are required to merge this pull request.

Assignees

@DylanTinianov DylanTinianov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DylanTinianov