Fix wheels workflow failures: smoke_test path and FFTW package name #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The wheels workflows were failing on both macOS and Linux platforms:
ci/smoke_test.pyRoot Causes
macOS Issue
The
test-commandinpyproject.tomlused a relative path (python ci/smoke_test.py). When cibuildwheel runs tests, it executes them from the installed wheel's site-packages directory, not the source directory, causing the test script to be unreachable.Linux Issue
The
ci/linux_before_all.shscript attempted to install thefftwpackage, but in manylinux_2_28 containers (based on AlmaLinux 8), the runtime library package is namedfftw-libs, notfftw.Solution
Fixed macOS wheels
Changed the test command to use cibuildwheel's
{project}placeholder:The
{project}placeholder references the source directory, allowing tests to locate the smoke test file regardless of the current working directory.Fixed Linux wheels
Updated the package name in the install script:
This ensures FFTW is properly installed in manylinux_2_28 containers using the correct package name.
Testing
These changes are minimal and use standard practices:
{project}placeholder is a documented cibuildwheel feature for accessing source files during testingfftw-libspackage name is the correct runtime library package for AlmaLinux 8-based containersThe build-test workflow continues to work correctly as it uses
$GITHUB_WORKSPACE/ci/smoke_test.py, which is appropriate for that context.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.