Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 18, 2025

Problem

The wheels workflows were failing on both macOS and Linux platforms:

  1. macOS wheels: Tests failed with "file not found" error when trying to run ci/smoke_test.py
  2. Linux wheels: Build failed because FFTW library was not being installed in manylinux containers

Root Causes

macOS Issue

The test-command in pyproject.toml used a relative path (python ci/smoke_test.py). When cibuildwheel runs tests, it executes them from the installed wheel's site-packages directory, not the source directory, causing the test script to be unreachable.

Linux Issue

The ci/linux_before_all.sh script attempted to install the fftw package, but in manylinux_2_28 containers (based on AlmaLinux 8), the runtime library package is named fftw-libs, not fftw.

Solution

Fixed macOS wheels

Changed the test command to use cibuildwheel's {project} placeholder:

-test-command  = "python ci/smoke_test.py"
+test-command  = "python {project}/ci/smoke_test.py"

The {project} placeholder references the source directory, allowing tests to locate the smoke test file regardless of the current working directory.

Fixed Linux wheels

Updated the package name in the install script:

-$PM -y install ... fftw fftw-devel ...
+$PM -y install ... fftw-libs fftw-devel ...

This ensures FFTW is properly installed in manylinux_2_28 containers using the correct package name.

Testing

These changes are minimal and use standard practices:

  • The {project} placeholder is a documented cibuildwheel feature for accessing source files during testing
  • The fftw-libs package name is the correct runtime library package for AlmaLinux 8-based containers

The build-test workflow continues to work correctly as it uses $GITHUB_WORKSPACE/ci/smoke_test.py, which is appropriate for that context.

Original prompt

The build-test workflow completes successfully, but the wheels workflows have errors. the macos-versions fail to find smoke_test.py file at the end. The linux-versions fail to locate fftw. Please fix


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: skilledwolf <18141588+skilledwolf@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix errors in wheels workflows for macos and linux Fix wheels workflow failures: smoke_test path and FFTW package name Oct 18, 2025
Copilot AI requested a review from skilledwolf October 18, 2025 22:14
@skilledwolf skilledwolf marked this pull request as ready for review October 18, 2025 22:26
@skilledwolf skilledwolf merged commit 00a5d3a into main Oct 18, 2025
12 checks passed
@skilledwolf skilledwolf deleted the copilot/fix-wheels-workflows-errors branch October 18, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants