Skip to content

Conversation

@dlundgren
Copy link
Contributor

Fixes #55 by restoring some of the logic from the pre-rc3 code for service validation.

@tvdijen tvdijen requested review from ioigoume and pradtke November 12, 2025 19:22
@pradtke
Copy link
Collaborator

pradtke commented Nov 14, 2025

Thanks for all these contributions @dlundgren . I'm out of office until middle of next week and then I can review this, and your other PRs.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.72%. Comparing base (008050c) to head (e25c7c0).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage     66.72%   66.72%           
- Complexity      349      351    +2     
=========================================
  Files            26       26           
  Lines          1190     1190           
=========================================
  Hits            794      794           
  Misses          396      396           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pradtke pradtke merged commit e7801a9 into simplesamlphp:master Nov 20, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unmatched legal cas service urls cause warnings in the log

2 participants