-
Notifications
You must be signed in to change notification settings - Fork 2
chore(deps): update hardhat packages #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
e392e86 to
870a354
Compare
| }, | ||
| "devDependencies": { | ||
| "@nomicfoundation/hardhat-ethers": "3.1.2", | ||
| "@nomicfoundation/hardhat-ethers": "3.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The Hardhat Network runtime defaults to the "Osaka" hardfork due to a dependency update, while contracts are compiled for "Cancun", creating a testing environment mismatch.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The update to EDR 0.12.0-next.17 changes the default Hardhat Network hardfork to "Osaka". However, the project's hardhat.config.ts specifies evmVersion: "cancun" for compilation without explicitly setting the network's hardfork. This mismatch between the compilation target (Cancun) and the test execution environment (Osaka) can cause tests to fail. Potential issues include gas cost discrepancies, unexpected EVM behavior due to new EIPs in Osaka, transaction failures from different default gas limits, and broken error message assertions. The test suite is tightly coupled to the Hardhat Network's behavior, making it sensitive to such environmental changes.
💡 Suggested Fix
Explicitly set the hardfork in hardhat.config.ts to match the compiler target. Add hardfork: "cancun" to the hardhat network configuration object to ensure the test execution environment is consistent with the compilation settings.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L63
Potential issue: The update to `EDR 0.12.0-next.17` changes the default Hardhat Network
hardfork to "Osaka". However, the project's `hardhat.config.ts` specifies `evmVersion:
"cancun"` for compilation without explicitly setting the network's hardfork. This
mismatch between the compilation target (Cancun) and the test execution environment
(Osaka) can cause tests to fail. Potential issues include gas cost discrepancies,
unexpected EVM behavior due to new EIPs in Osaka, transaction failures from different
default gas limits, and broken error message assertions. The test suite is tightly
coupled to the Hardhat Network's behavior, making it sensitive to such environmental
changes.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7517490
870a354 to
d4303c5
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
d4303c5 to
a2185e1
Compare
This PR contains the following updates:
3.1.2→3.1.34.1.1→4.1.22.27.1→2.28.2Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
NomicFoundation/hardhat (@nomicfoundation/hardhat-ethers)
v3.1.3Compare Source
This release updates the default gas limit to take into account the Osaka transaction limit.
Changes
c69b99d: Update default gas limit to take into account osaka transaction limit (#7751)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.