-
Notifications
You must be signed in to change notification settings - Fork 2
fix: configure setup-dependencies for SDK repo #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove separate Node.js setup step (now handled by shared action with registry-url) - Disable unused tools: foundry, helm, helm-docs, python, chart-testing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
PR SummaryOptimizes CI by consolidating Node setup into
Written by Cursor Bugbot for commit 3a06e87. This will update automatically on new commits. Configure here. |
|
To view in Slack, search for: 1767290183.807949 |
…flow - Added 'runner: github' parameter to the setup-dependencies action to specify the execution environment. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
|
Warning Rate limit exceeded@roderik has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 53 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Changed Node.js version from 24.12.0 to 24 to align with the latest requirements.
| disable_helm: "true" | ||
| disable_helm_docs: "true" | ||
| disable_python: "true" | ||
| disable_chart_testing: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing registry-url parameter for npm OIDC publishing
The change removes the explicit actions/setup-node step that configured registry-url: "https://registry.npmjs.org", which is required for npm OIDC publishing with provenance. The new setup-dependencies action doesn't receive a registry_url parameter. Without this configuration, npm publish --provenance commands in the package scripts (e.g., sdk/blockscout/package.json) will fail because npm won't be able to perform OIDC token exchange with the registry. The PR description mentions registry-url handling but the parameter isn't visible in the configuration.
Summary
registry-urlfor npm OIDC)This reduces CI time by not installing tools the SDK repo doesn't need.
Test plan
🤖 Generated with Claude Code
Summary by cubic
Switch CI to shared-actions/setup-dependencies for Node and npm OIDC, remove the standalone setup-node step, and align .node-version to 24. Disable unused tools to cut CI time.
Written for commit 3a06e87. Summary will update on new commits.