Skip to content

Conversation

@roderik
Copy link
Member

@roderik roderik commented Jan 1, 2026

Summary

  • Removes the separate Node.js setup step (now handled by shared-actions/setup-dependencies with registry-url for npm OIDC)
  • Disables unused tools in setup-dependencies: foundry, helm, helm-docs, python, chart-testing

This reduces CI time by not installing tools the SDK repo doesn't need.

Test plan

  • Verify CI passes
  • Verify npm publish works with OIDC

🤖 Generated with Claude Code


Summary by cubic

Switch CI to shared-actions/setup-dependencies for Node and npm OIDC, remove the standalone setup-node step, and align .node-version to 24. Disable unused tools to cut CI time.

  • Refactors
    • Set runner: github for setup-dependencies; updated .node-version to 24.
    • Disabled tools: foundry, helm, helm-docs, python, chart-testing.

Written for commit 3a06e87. Summary will update on new commits.

- Remove separate Node.js setup step (now handled by shared action with registry-url)
- Disable unused tools: foundry, helm, helm-docs, python, chart-testing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@cursor
Copy link

cursor bot commented Jan 1, 2026

PR Summary

Optimizes CI by consolidating Node setup into setup-dependencies and disabling unused tooling.

  • Configures setup-dependencies with runner: github and disables foundry, helm, helm-docs, python, and chart-testing in qa.yml
  • Removes standalone Node setup step; Node is now handled by setup-dependencies
  • Updates .node-version from 24.12.0 to 24

Written by Cursor Bugbot for commit 3a06e87. This will update automatically on new commits. Configure here.

@github-actions github-actions bot added the qa:running QA workflow is currently running label Jan 1, 2026
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

To view in Slack, search for: 1767290183.807949

@github-actions github-actions bot added the status:ready-for-review Pull request is ready for review label Jan 1, 2026
…flow

- Added 'runner: github' parameter to the setup-dependencies action to specify the execution environment.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

Warning

Rate limit exceeded

@roderik has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 53 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5adc63e and 3a06e87.

📒 Files selected for processing (2)
  • .github/workflows/qa.yml
  • .node-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- Changed Node.js version from 24.12.0 to 24 to align with the latest requirements.
@roderik roderik merged commit c66d59a into main Jan 1, 2026
9 of 10 checks passed
@roderik roderik deleted the fix/setup-dependencies-config branch January 1, 2026 18:01
@github-actions github-actions bot added qa:failed QA workflow failed status:merged Pull request has been merged status:ready-for-review Pull request is ready for review and removed qa:running QA workflow is currently running status:ready-for-review Pull request is ready for review status:merged Pull request has been merged labels Jan 1, 2026
disable_helm: "true"
disable_helm_docs: "true"
disable_python: "true"
disable_chart_testing: "true"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing registry-url parameter for npm OIDC publishing

The change removes the explicit actions/setup-node step that configured registry-url: "https://registry.npmjs.org", which is required for npm OIDC publishing with provenance. The new setup-dependencies action doesn't receive a registry_url parameter. Without this configuration, npm publish --provenance commands in the package scripts (e.g., sdk/blockscout/package.json) will fail because npm won't be able to perform OIDC token exchange with the registry. The PR description mentions registry-url handling but the parameter isn't visible in the configuration.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa:failed QA workflow failed status:ready-for-review Pull request is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants