Skip to content

Conversation

@natea
Copy link

@natea natea commented Sep 30, 2025

Summary

  • Changed default googleAuthEnabled state from true to false in AuthContext
  • Prevents Google Auth screen from appearing when authentication is disabled in the application

Changes

  • Modified src/client/react/src/contexts/AuthContext.tsx to set googleAuthEnabled initial state to false

Test plan

  • Verify Google Auth prompt does not appear when authentication is disabled
  • Test application startup behavior
  • Confirm auth flow works correctly when Google Auth is explicitly enabled

🤖 Generated with Claude Code

…isabled

Initialize googleAuthEnabled state to false instead of true to avoid displaying
the Google Sign-In UI during the authentication initialization window.

Previously, googleAuthEnabled defaulted to true, causing a race condition where:
1. Component rendered with googleAuthEnabled=true
2. Google Sign-In button appeared immediately
3. API call to /api/auth/status was made asynchronously
4. Only after the response would bypass auth be triggered

This caused the Google Auth screen to flash even when ENABLE_GOOGLE_AUTH="false"
was set in the server .env configuration.

With this change, the authentication flow now:
1. Starts with Google Auth disabled (matches expected state)
2. Shows loading state during initialization
3. Automatically authenticates via bypass when server confirms it's disabled
4. Only enables Google Auth UI if server explicitly reports it's enabled

Related files:
- Server config: src/server/.env (ENABLE_GOOGLE_AUTH="false")
- Auth logic: src/server/authorization/auth.py

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @natea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the Google authentication prompt could be displayed even when Google authentication was not explicitly enabled. By adjusting the default state of the googleAuthEnabled flag within the application's authentication context, the change ensures that the Google Auth screen only appears when intended, leading to a more consistent and expected authentication flow.

Highlights

  • Google Authentication Default State: The default value for googleAuthEnabled in the AuthContext has been changed from true to false.
  • Preventing Unintended Google Auth Screen: This modification ensures that the Google authentication screen does not appear when authentication is disabled in the application, improving the user experience.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly resolves an issue where the Google Authentication screen would briefly appear even when disabled. By changing the initial state of googleAuthEnabled to false, you've eliminated a race condition that was causing a UI flicker on application load. This is a clean and effective fix that improves the user experience. The change is concise and well-targeted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant