Skip to content

Conversation

@ibevers
Copy link
Contributor

@ibevers ibevers commented Jan 6, 2025

Ensures that only CLI specific code is in commands.py and all general-purpose code is in reusable modules.

@ibevers ibevers linked an issue Jan 6, 2025 that may be closed by this pull request
@satra
Copy link
Contributor

satra commented Jan 17, 2025

@ibevers - can you describe what this is for? also does pre-commit not handle some of the stylistic components for this?

@ibevers
Copy link
Contributor Author

ibevers commented May 13, 2025

@ibevers - can you describe what this is for? also does pre-commit not handle some of the stylistic components for this?

There is general purpose logic in commands.py that should be refactored into reusable modules. I feel that commands.py should have only code that is specific to the CLI interface, and everything else should be imported from general-purpose modules.

def create_derived_dataset(bids_path, outdir):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor commands.py

3 participants