Skip to content

Conversation

@bburda
Copy link
Contributor

@bburda bburda commented Jan 27, 2026

Description

Update manifest path, params and manifest file for proper discovery.

Related Issue

closes #15

Checklist

  • Tested locally
  • README updated (if needed)

@bburda bburda requested a review from mfaferek93 January 27, 2026 19:45
@bburda bburda self-assigned this Jan 27, 2026
Copilot AI review requested due to automatic review settings January 27, 2026 19:45
@bburda bburda added the bug Something isn't working label Jan 27, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the sensor diagnostics demo where an incorrect manifest parameter name prevented the manifest from being used for discovery, causing the demo to always run in runtime discovery mode. The fix updates the parameter structure to match the current ros2_medkit_gateway API and enhances the manifest with more detailed component and app definitions.

Changes:

  • Fixed manifest parameter name from nested manifest.path to flat manifest_path in launch file and configuration
  • Updated discovery configuration structure with explicit discovery_mode parameter set to "hybrid"
  • Enhanced sensor manifest with detailed app definitions using ros_binding, explicit component types, and added missing components (fault-manager, diagnostic-bridge-unit)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
demos/sensor_diagnostics/launch/demo.launch.py Changed manifest parameter from manifest.path to manifest_path to match updated API
demos/sensor_diagnostics/config/medkit_params.yaml Restructured discovery configuration with flat parameter names, added discovery_mode: "hybrid", and increased refresh interval to reduce logging
demos/sensor_diagnostics/config/sensor_manifest.yaml Added config section, component types, comprehensive apps section with ros_binding details, and functions section for better manifest-based discovery
demos/sensor_diagnostics/Dockerfile Removed outdated comparison comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bburda bburda merged commit c41c211 into main Jan 28, 2026
8 checks passed
@bburda bburda deleted the fix/manifest-configuration branch January 28, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Invalid manifest param in sensors demo

3 participants