PV node support: Small refactor - Use internal topology #1
+103
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work in progress, hence marked as draft.
The purpose of this PR is to help addressing some things that were pointed out in PowerGridModel#1220. Specifically:
u_refandbus_types(not mentioned in-comments but to be addressed by us) - c5175abgenerator_id()handling (PV node: feature #185 PowerGridModel/power-grid-model#1220 (comment)) - to be donecalculate_voltage_regulator_result()instead of additional mappings (not mentioned in-comments but to be addressed by us; c.f.r.power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/common_solver_functions.hpp
Line 147 in 5092b50
These are things to be picked up by the power grid model maintainers (Can you please tag @mgovers, @nitbharambe and @petersalemink95, I don't seem to be able to tag them because I had to open this PR on your fork).