Skip to content

Conversation

@junior-od
Copy link
Contributor

@junior-od junior-od commented Jan 13, 2026

Contributor checklist


Description

This pull request fixes an issue where conjugation results did not respect the capitalization of the input verb.
Previously, when users entered a capitalized or all-caps verb (for example, Sein or HABEN), the generated conjugations were returned entirely in lowercase, which broke consistency with the user’s input and reduced readability. This change ensures that when a capitalized verb is provided, the conjugated forms are returned in a normalized title-case format (only the first letter of each form is capitalized).

What was changed

  1. handleConjugateState()
  • Now detects whether the input verb is capitalized (title case or all caps).
  1. applyCapitalizationToConjugations() (new helper)
  • Transforms the conjugation output so that only the first character of each conjugated form is capitalized when needed.
  1. handlePluralOrTranslateState()
  • Enhanced handlePluralOrTranslateState() to detect and preserve ALL CAPS formatting

Conjugation map processing
Capitalization is now applied consistently to all conjugated forms in the result structure.

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis
Copy link
Member

Thanks so much for the PR and your interest in the project, @junior-od! We'll try to get to the review in the coming days :)

@DeleMike and/or @angrezichatterbox: Would either of you have a moment for an initial review? I'll also do a check maybe tomorrow night, but just in case either of you have time before :)

@DeleMike
Copy link
Collaborator

Sure @andrewtavis , I will add my review today.

Copy link
Collaborator

@DeleMike DeleMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @junior-od, please look into my comment to know what to adjust.

Thank you again for contributing :)

@junior-od junior-od requested a review from DeleMike January 14, 2026 16:35
Copy link
Collaborator

@DeleMike DeleMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is very good @junior-od!

Thank you so much! Just a little comment/docstring issue which I don't think is necessary but I could be wrong.

Approved!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's working really well here, @junior-od! Thanks for the great implementation here and for reacting to requests from reviewers 😊

praise: Thanks for the detailed first review here, @DeleMike!

Glad to have this finished :) Great work, all!

@andrewtavis andrewtavis merged commit b39d5b2 into scribe-org:main Jan 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capitalize conjugations if the entered text is capitalized

3 participants