-
Notifications
You must be signed in to change notification settings - Fork 99
fix: Capitalize conjugations when input verb is capitalized #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Capitalize conjugations when input verb is capitalized #534
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Thanks so much for the PR and your interest in the project, @junior-od! We'll try to get to the review in the coming days :) @DeleMike and/or @angrezichatterbox: Would either of you have a moment for an initial review? I'll also do a check maybe tomorrow night, but just in case either of you have time before :) |
|
Sure @andrewtavis , I will add my review today. |
DeleMike
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @junior-od, please look into my comment to know what to adjust.
Thank you again for contributing :)
DeleMike
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is very good @junior-od!
Thank you so much! Just a little comment/docstring issue which I don't think is necessary but I could be wrong.
Approved!
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: All's working really well here, @junior-od! Thanks for the great implementation here and for reacting to requests from reviewers 😊
praise: Thanks for the detailed first review here, @DeleMike!
Glad to have this finished :) Great work, all!
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This pull request fixes an issue where conjugation results did not respect the capitalization of the input verb.
Previously, when users entered a capitalized or all-caps verb (for example, Sein or HABEN), the generated conjugations were returned entirely in lowercase, which broke consistency with the user’s input and reduced readability. This change ensures that when a capitalized verb is provided, the conjugated forms are returned in a normalized title-case format (only the first letter of each form is capitalized).
What was changed
Conjugation map processing
Capitalization is now applied consistently to all conjugated forms in the result structure.
Related issue
Closes Capitalize conjugations if the entered text is capitalized #523