[WIP] Live m3 follow up #9102
[WIP] Live m3 follow up #9102
Conversation
…collab is turned on
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…of own merge action while rebasing, the proofread saga is doing this already
…freading helper mesh auto reloading
| @@ -12,7 +12,7 @@ import type ApiLoader from "./api_loader"; | |||
| // for debugging or one off scripts. | |||
| export const WkDevFlags = { | |||
| logActions: false, | |||
| liveCollab: false, | |||
| liveCollab: true, | |||
There was a problem hiding this comment.
TODO: undo
| // TODOM: in my test case this is wrong! | ||
| // TODOM: this breaks segment list syncing.! -> maybe removes mesh as well :thinking: | ||
| // yield* put(removeSegmentAction(targetAgglomerateId, volumeTracingId)); |
There was a problem hiding this comment.
There are edge cases where targetAgglomerateId when updated before this operation is wrong / outdated. Same for using the original targetInfo.agglomerateId information to remove the correct segment from the segment list. Therefore, I disabled this for now. This should be done correctly in live m4.
But this is breaking my tests as removing the wrong segment auto removes the mesh with it -> accidentally deleting an auxiliary mesh which should instead still exist.
…rom store; instead always derive it from the store state
- Some are still broken
… to enable correct proofreading action post processing like auto updating agglomerate skeletons
…ore the actual user's mapping changes is now used for the other proofreading sub sagas as well
…ntext when loading
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)
$PR_NUMBER.mdfile inunreleased_changesor use./tools/create-changelog-entry.py)