-
Notifications
You must be signed in to change notification settings - Fork 0
Fix logical flaws in AuthorDiversityScorer and WeightedScorer #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Fix `AuthorDiversityScorer`: prevent boosting of negative scores by only applying diversity decay to positive scores. Previously, multiplying a negative score by a factor < 1 resulted in a less negative score (boosting it). - Fix `WeightedScorer`: fix discontinuity in `offset_score` function at zero. Previously, negative scores were handled by a formula that caused a jump in the score function at 0. Now using a continuous linear offset for all scores.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
@jules write me a before and after test, keep the test script and please provide evidence of improvement or scenario that is easily explained |
I have added a test script Here is the output from running the script: The script is included in the PR commit. |
- Fix `AuthorDiversityScorer`: prevent boosting of negative scores by only applying diversity decay to positive scores. - Fix `WeightedScorer`: fix discontinuity in `offset_score` function at zero by using a linear offset for all scores. - Add `home-mixer/demonstrate_fixes.rs`: A standalone Rust script to verify the fixes and demonstrate the before/after behavior.
- Fix `AuthorDiversityScorer`: prevent boosting of negative scores by only applying diversity decay to positive scores. - Fix `WeightedScorer`: fix discontinuity in `offset_score` function at zero by using a linear offset for all scores. - Add `home-mixer/demonstrate_fixes.rs`: A standalone Rust script to verify the fixes and demonstrate the before/after behavior.
- Provided a drafted tweet to explain the bug simply as requested.
This change addresses two logical flaws in the
home-mixerranking algorithms:offset_scorefunction had a discontinuity at 0 due to a special formula for negative inputs. This resulted in arbitrary score jumps for candidates crossing the zero threshold. The fix unifies the offset logic to be linear and continuous for all inputs.PR created automatically by Jules for task 13179902545450204237 started by @sashimikun