FEATURE: Make TOTP verification window configurable #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add totpVerificationWindow setting to allow operators to configure the tolerance for TOTP code verification. - Add optional $window parameter to TOTPService::checkIfOtpIsValid() - Inject configuration in LoginController and BackendController - Default to 0 (strict, original behavior) for backward compatibility - Document the new setting in README.md Setting totpVerificationWindow to 1 is recommended as it prevents authentication failures caused by: - Clock drift between user device and server - Period boundary race conditions (code generated at end of period) - Network latency during code submission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add totpVerificationWindow setting to allow operators to configure the tolerance for TOTP code verification.
Setting totpVerificationWindow to 1 is recommended as it prevents authentication failures caused by: