Skip to content

Conversation

@Datalux
Copy link

@Datalux Datalux commented Nov 8, 2020

Some subnets are not found, so with 192.168.*.* its can looking for all possible subnet.
Maybe this can be more complex but can found more results.

@samyk
Copy link
Owner

samyk commented Nov 8, 2020

I appreciate the PR. The challenge with this adjustment is the amount of time it will take to complete. I suppose now that there are callbacks, it's not as big of a deal, but anyone depending on the main function to return is going to have to wait orders of magnitude longer and it already takes a minute or so where this will now take hours.

If we can increase the speed significantly I'd be open to an adjustment like this. It was much faster using img tags, however that was not cross-browser and removing the img tag or changing the src didn't seem to kill the connection, where fetch() is able to be aborted properly.

samyk added a commit that referenced this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants