gadget: add --pid1 mode #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48f6f0e863
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
samcday
commented
Jan 21, 2026
Owner
Author
|
@codex can you fix the review comments? |
|
To use Codex here, create an environment for this repo. |
Owner
Author
|
@codex can you fix the review comments? |
|
Summary
Testing
|
samcday
force-pushed
the
stage0-pid1
branch
2 times, most recently
from
ee62302 to
8cfb76e
Compare
This option is automatically enabled if arg0 == /init If enabled and $PID != 1, error. Otherwise, cosplay as a cursed initrd. Mount the absolute minimum VFS, probe the minimum extra modules, in order to get a UDC to appear. Then, fork a typical smoo-gadget. Once that brings up a rootfs, we pivot into that. We assume we're pivoting into a systemd pid1, and seed /run/systemd/system with a unit to ensure that smoo-gadget is adopted properly in the live system. Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is automatically enabled if arg0 == /init
If enabled and $PID != 1, error.
Otherwise, cosplay as a cursed initrd. Mount the absolute minimum VFS, probe the minimum extra modules, in order to get a UDC to appear. Then, fork a typical smoo-gadget. Once that brings up a rootfs, we pivot into that.
We assume we're pivoting into a systemd pid1, and seed /run/systemd/system with a unit to ensure that smoo-gadget is adopted properly in the live system.
Assisted-by: gpt-5.1-codex